fix: only show previous session when in edit mode #7737
Merged
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the previous session was being shown in RUN mode when it should only be displayed in EDIT mode. The fix adds an additional condition to the CachingExtension initialization to ensure caching is only enabled in EDIT mode.
- Modified the CachingExtension initialization to include a mode check (
mode == SessionMode.EDIT) - Added a test to verify that caching is only enabled in EDIT mode with auto_instantiate=False
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| marimo/_session/session.py | Added SessionMode.EDIT check to CachingExtension initialization condition |
| tests/_server/test_sessions.py | Added test to verify caching is enabled only in EDIT mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously would show the previous session in Run, when we only want to do this in edit mode.
Supersedes #7619