Skip to content

Conversation

@jpopesculian
Copy link

📝 Summary

When running the notebook with the RUN command, the session gets serialized out of order if the cells execute out of order. This makes the serialized session unusable as it will not be a "cache_hit". The SessionCacheManager doesn't currently have access to the cell_ids to serialize the cells in order.

🔍 Description of Changes

The change here adds a cell_ids_provider to the SessionCacheManager in order for it to have knowledge of the cell_ids.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Dec 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Dec 28, 2025 10:32am

@github-actions
Copy link

github-actions bot commented Dec 28, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jpopesculian
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@mscolnick
Copy link
Contributor

It might be a bug/oversight that this is even enabled for run mode. I'd imagine that showing previous sessions would be undesired since you'd have different users overwriting each other (and potentially with different info that doesn't make sense).

mscolnick added a commit that referenced this pull request Jan 8, 2026
We previously would show the previous session in Run, when we only want
to do this in edit mode.

Supersedes #7619

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants