fix: serialize run sessions in cell order #7619
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When running the notebook with the RUN command, the session gets serialized out of order if the cells execute out of order. This makes the serialized session unusable as it will not be a "cache_hit". The SessionCacheManager doesn't currently have access to the cell_ids to serialize the cells in order.
🔍 Description of Changes
The change here adds a
cell_ids_providerto the SessionCacheManager in order for it to have knowledge of the cell_ids.📋 Checklist