Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented May 29, 2025

This change is a follow up for #827 and #834 and maps TOGGLE_FAST_FORWARD_REPLAY to F, SELECT_ALL_AIRCRAFT to W by default. That way, Generals no longer requires a modified CommandMap.ini to have these new mappings. Mappings from CommandMap.ini will override the code defaults.

TODO

  • Remove default for SELECT_ALL_AIRCRAFT

@xezon xezon requested a review from Skyaero42 May 29, 2025 09:36
@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels May 29, 2025
@xezon xezon force-pushed the xezon/add-default-key-mapping branch from 61cd745 to e64bdeb Compare May 29, 2025 09:43
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@xezon
Copy link
Author

xezon commented May 31, 2025

On second thought, I think we should disable the default for SELECT_ALL_AIRCRAFT. It will create key conflicts in some languages, most notably German.

@xezon xezon force-pushed the xezon/add-default-key-mapping branch from e64bdeb to 59bb3e9 Compare June 1, 2025 07:27
@xezon xezon changed the title [GEN][ZH] Implement default key mappings for TOGGLE_FAST_FORWARD_REPLAY, SELECT_ALL_AIRCRAFT [GEN][ZH] Implement default key mapping for TOGGLE_FAST_FORWARD_REPLAY Jun 1, 2025
@xezon
Copy link
Author

xezon commented Jun 1, 2025

Rebased on Main. Default mapping for SELECT_ALL_AIRCRAFT removed.

@xezon xezon merged commit cc0e461 into TheSuperHackers:main Jun 1, 2025
21 checks passed
@xezon xezon deleted the xezon/add-default-key-mapping branch June 1, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants