Skip to content

[GEN][ZH] Implement feature to Pause and Step Frames in Replay playback #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xezon merged 4 commits into from
May 31, 2025
Merged

[GEN][ZH] Implement feature to Pause and Step Frames in Replay playback #969

xezon merged 4 commits into from
May 31, 2025

Conversation

@xezon
Copy link

@xezon xezon commented May 29, 2025

This change implements replay pausing and frame stepping. This is useful for inspecting specific frames.

The default key bindings are

  • P: Pause
  • O: Step 1 frame

Pausing a replay this way will

  • Pause Logic
  • Pause Sound
  • Not pause Music
  • Not pause Input

Pausing with Exit menu will pause as usual:

  • Pause Logic
  • Pause Sound
  • Pause Music
  • Pause Input

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels May 29, 2025
@xezon xezon mentioned this pull request May 23, 2025
Open
34 tasks
@xezon xezon requested a review from a team May 29, 2025 09:15
@xezon xezon mentioned this pull request May 29, 2025
Merged
1 task
@xezon xezon requested a review from Skyaero42 May 29, 2025 18:52
@Skyaero42
Copy link

Skyaero42 commented May 29, 2025

Code looks good. I want to give it a few tests before approving

This was referenced May 30, 2025
Merged
Merged
@xezon xezon changed the title [GEN][ZH] Implement feature to pause and step frames in replay playback [GEN][ZH] Implement feature to Pause and Step Frames in Replay playback May 31, 2025
Skyaero42
Skyaero42 approved these changes May 31, 2025
View reviewed changes
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm.

@xezon xezon merged commit 4a723fd into TheSuperHackers:main May 31, 2025
19 checks passed
@Skyaero42 Skyaero42 mentioned this pull request Jun 2, 2025
Open
@xezon xezon deleted the xezon/add-pause-replay-feature branch June 2, 2025 15:49
@xezon xezon mentioned this pull request Jul 24, 2025
Open
@xezon xezon mentioned this pull request Sep 3, 2025
Merged
1 task
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@xezon
[GEN][ZH] Implement feature to Pause and Step Frames in Replay playba…
55541ec 
…ck (TheSuperHackers#969)

Press P to Pause and O to Step 1 Frame in Replay playback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skyaero42 Skyaero42 Skyaero42 approved these changes

+1 more reviewer

@abolpool abolpool abolpool approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xezon @Skyaero42 @abolpool