Replaced GitRef.hpp manual generation with template file GitRef.hpp.in #1225
+46
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids executing commands during the build process to generate the file manually.
PysKa-Ratzinger
force-pushed
the
master
branch
from
4b7447d to
af9a45f
Compare
Author
|
Emscripten build seems to fail due to a re-configure of CMake (because GitRef.hpp was generated during configure, and so it's database of files change, or something like that), so I moved the file generation into the build step. |
Author
|
Ok, so I was wrong. Not sure what is happening with the Emscripten build. Will need someone with more CMake knowledge to help here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids executing commands during the build process to generate the file manually.
It also fixes a problem where the "git log" command will depend on the user's .gitconfig, which in my case contained "log.showSignature = true", which polutes the generated file.
Tested on Linux platform only, with git installed.