fixme: SwiftLint updated universal downloads since release 0.58.0.

[0x41c]

Issue/Discussion.

Since version 0.50.0, SwiftLint has been using a new naming scheme and format (no longer portable_swiftlint.zip) for their universal releases (now called Universal MacOS Binary- a binary file). If support for older versions is valuable but changes to trunk are not wanted, renaming older versions to swiftlint-legacy and appending the new download under swiftlint could resolve this, although it would be breaking for few. Otherwise, a few options are available:

• Allow alternative links for downloads (ex: when a status code of 404 is hit continuously).
• Allow versioned downloads under the same name (or equivalently but more ambiguously, url becomes urls with order-priority).

  • This requires trunk perform unarchiving optionally which could be already implemented.

• As previously mentioned, redefine the current swiftlint plugin as swiftlint-legacy (slightly breaking for older workflows) and through a replacement plugin fix the download.

There may be other fixes that I am not aware of but hopefully this gets the ball rolling :)

[TylerJang27]

Hi! Thanks for reporting this. We already support some level of versioned downloads with varied unarchiving. I'll try to take a look at this this week and let you know. Would you be able to try out a test branch at that point and let me know if it fixes your issue?

[0x41c]

For sure. Is there anything I should be prepared to do to validate these changes or is the outline in CONTRIBUTING.md sufficient?

[TylerJang27]

Hi, sorry for the delay. I finally had some time to look into this. It looks like the naming scheme hasn't changed. The path of the download is still portable_swiftlint.zip even though its name in the artifacts has (e.g. https://github.com/realm/SwiftLint/releases/download/0.62.2/portable_swiftlint.zip). I'm able to run trunk check enable swiftlint@0.62.2 and trunk check --filter=swiftlint <filepath> without issues. If you're still having problems, can you paste the error log that you see when you run trunk check and I can debug that further?