topology2: cavs: Add SDW speaker,headset,hdmi and DMIC support #6562
Conversation
This patch adds topology support to external SDW audio interface card (aic) with spk amp on SDW0 and headset codec on SDW2 along with DMIC and HDMI. Hence, adding the entries for the same to match with below BE order: SDW2-Playback, id 0 SDW2-Capture, id 1 SDW0-Playback, id 2 SDW0-Capture, id 3 dmic01, id 4 dmic16k, id 5 iDisp1, id 6 iDisp2, id 7 iDisp3, id 8 iDisp4, id 9 Signed-off-by: Yong Zhi <yong.zhi@intel.com> Signed-off-by: jairaj-arava <jairaj.arava@intel.com>
jairaj-arava
requested review from
aborisovich,
dbaluta,
lbetlej,
lgirdwood,
marc-hb,
mmaka1 and
plbossart
as code owners
| } | ||
|
|
||
| Define { | ||
| NUM_HDMIS 0 |
| #SDW2-Headset codec, SDW0-Spk amp | ||
| # | ||
| Object.Dai { | ||
| ALH."514" { |
There was a problem hiding this comment.
where is this 514/515 coming from?
There was a problem hiding this comment.
it's a mess. We need to compute the ALH identifiers from the position of the links and PDIs, not hard-code like this.
It seems like with topology2 everyone forgot about the need to configure multiple hardware layouts as we did for topology1.
There was a problem hiding this comment.
and it's again completely wrong to create a new topology per card, we've got to reuse reuse and reuse.
There was a problem hiding this comment.
Hi @ranj063 and @plbossart ,
Sorry for the delay in response, understood your comments. Had a discussion with @bardliao , and he is already working on this in #6549. Hence, to avoid redundancy, closing this PR and will work with Bard.
Thanks.
This patch adds topology support to external SDW audio interface card (aic) with spk amp on SDW0 and headset codec on SDW2 along with DMIC and HDMI.
Hence, adding the entries for the same to match with below BE order:
SDW2-Playback, id 0
SDW2-Capture, id 1
SDW0-Playback, id 2
SDW0-Capture, id 3
dmic01, id 4
dmic16k, id 5
iDisp1, id 6
iDisp2, id 7
iDisp3, id 8
iDisp4, id 9
Signed-off-by: Yong Zhi yong.zhi@intel.com
Signed-off-by: jairaj-arava jairaj.arava@intel.com