Limit supported vulkan version in skia initialization #10398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbalt
changed the title
kbalt
changed the title
kbalt
force-pushed
the
skia-vulkan-wgpu-fixes
branch
2 times, most recently
from
278ea3b to
b1c43fa
Compare
Member
|
cc @jturcotte |
tronical
reviewed
Jan 9, 2026
Member
tronical
left a comment
tronical
left a comment
There was a problem hiding this comment.
Thanks! That makes sense, I think. One question inside :)
| wgpu::TextureFormat::Rgba8Unorm => { | ||
| (skia_safe::gpu::vk::Format::R8G8B8A8_UNORM, skia_safe::ColorType::RGBA8888) | ||
| } | ||
| wgpu::TextureFormat::Rgba8UnormSrgb => { |
Member
There was a problem hiding this comment.
This looks like an unintentional change. Is That correct?
Contributor
Author
There was a problem hiding this comment.
Yes, sorry - removed it.
kbalt
force-pushed
the
skia-vulkan-wgpu-fixes
branch
from
b1c43fa to
b63bf6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits skia's vulkan version to the maximum wgpu supports.
Skia fails to initialize if the physical device supports Vulkan 1.4 but not the
VK_EXT_host_image_copyextension. Since WGPU only creates an Instance with Vulkan 1.3, where theVK_EXT_host_image_copyextension isn't yet part of Vulkan Core, the function isn't properly loaded in skia's validation.Limiting the API version makes skia not assume usage of Vulkan 1.4