Skip to content

improvement(modal): fixed popover issue in custom tools modal, removed the ability to update if no changes made #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Jan 20, 2026
Merged

improvement(modal): fixed popover issue in custom tools modal, removed the ability to update if no changes made #2897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51b5d32
improvement(modal): fixed popover issue in custom tools modal, remove…
waleedlatif1 Jan 20, 2026
25fb12d
improvement(modal): fixed popover issue in custom tools modal, remove…
waleedlatif1 Jan 20, 2026
95728e3
popover fixes, color picker keyboard nav, code simplification
waleedlatif1 Jan 20, 2026
fa748bb
color standardization
waleedlatif1 Jan 20, 2026
7817113
fix color picker
waleedlatif1 Jan 20, 2026
83416ba
set discard alert state when closing modal
waleedlatif1 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal/base-tags-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,15 +462,15 @@ export function BaseTagsModal({ open, onOpenChange, knowledgeBaseId }: BaseTagsM
<ModalHeader>Documents using "{selectedTag?.displayName}"</ModalHeader>
<ModalBody>
<div className='space-y-[8px]'>
<p className='text-[12px] text-[var(--text-tertiary)]'>
<p className='text-[12px] text-[var(--text-secondary)]'>
{selectedTagUsage?.documentCount || 0} document
{selectedTagUsage?.documentCount !== 1 ? 's are' : ' is'} currently using this tag
definition.
</p>

{selectedTagUsage?.documentCount === 0 ? (
<div className='rounded-[6px] border p-[16px] text-center'>
<p className='text-[12px] text-[var(--text-tertiary)]'>
<p className='text-[12px] text-[var(--text-secondary)]'>
This tag definition is not being used by any documents. You can safely delete it
to free up the tag slot.
</p>
Expand Down
2 changes: 1 addition & 1 deletion ...components/panel/components/deploy/components/deploy-modal/components/general/general.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export function GeneralDeploy({
<ModalContent size='sm'>
<ModalHeader>Promote to live</ModalHeader>
<ModalBody>
<p className='text-[12px] text-[var(--text-tertiary)]'>
<p className='text-[12px] text-[var(--text-secondary)]'>
Are you sure you want to promote{' '}
<span className='font-medium text-[var(--text-primary)]'>
{versionToPromoteInfo?.name || `v${versionToPromote}`}
Expand Down
5 changes: 2 additions & 3 deletions .../[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,12 +591,11 @@ export function DeployModal({
)}
{activeTab === 'api' && (
<ModalFooter className='items-center justify-between'>
<div>
<div />
<div className='flex items-center gap-2'>
<Button variant='default' onClick={() => setIsApiInfoModalOpen(true)}>
Edit API Info
</Button>
</div>
<div className='flex items-center gap-2'>
<Button
variant='tertiary'
onClick={() => setIsCreateKeyModalOpen(true)}
Expand Down
6 changes: 3 additions & 3 deletions .../editor/components/sub-block/components/tool-input/components/code-editor/code-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function CodeEditor({
placeholder = '',
className = '',
gutterClassName = '',
minHeight = '360px',
minHeight,
highlightVariables = true,
onKeyDown,
disabled = false,
Expand Down Expand Up @@ -186,7 +186,7 @@ export function CodeEditor({
}

return (
<Code.Container className={className} style={{ minHeight }}>
<Code.Container className={className} style={minHeight ? { minHeight } : undefined}>
{showWandButton && onWandClick && (
<Button
variant='ghost'
Expand Down Expand Up @@ -220,7 +220,7 @@ export function CodeEditor({
disabled={disabled}
{...getCodeEditorProps({ disabled })}
className={cn(getCodeEditorProps({ disabled }).className, 'h-full')}
style={{ minHeight }}
style={minHeight ? { minHeight } : undefined}
textareaClassName={cn(
getCodeEditorProps({ disabled }).textareaClassName,
'!block !h-full !min-h-full'
Expand Down
Loading