Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

added 404 page

Type of Change

  • New feature

Testing

Tested manually.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Screenshot 2025-09-20 at 2 32 54 PM

@vercel
Copy link

vercel bot commented Sep 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sim Building Building Preview Comment Sep 20, 2025 9:35pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Sep 20, 2025 9:35pm

@waleedlatif1 waleedlatif1 merged commit 6b4ebba into staging Sep 20, 2025
4 of 5 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/404 branch September 20, 2025 21:35
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds a custom 404 page to the application and improves branding consistency across error/status pages. The main addition is a new not-found.tsx file that creates a 404 page matching the application's authentication theme and branding system. The page features dynamic button styling that adapts to custom brand colors through CSS custom properties, automatic dark/light theme detection using color luminance calculations, and proper cleanup of event listeners and mutation observers.

The PR also updates the invite status card component to use dynamic brand configuration instead of hardcoded values. Specifically, it replaces the hardcoded support email 'help@sim.ai' with brandConfig.supportEmail, making the contact information configurable through environment variables. This change aligns with the branding approach used in the new 404 page and removes some unused icon rendering code to simplify the UI.

The 404 page implementation follows existing patterns in the codebase by reusing components like AuthBackground and Nav, ensuring visual consistency with other auth-style pages. The sophisticated brand detection logic allows the page to work seamlessly with white-label deployments by detecting custom brand configurations and adjusting styling accordingly. Users encountering non-existent pages will now see a cohesive experience with helpful navigation options back to the workspace and support contact information.

Confidence score: 4/5

  • This PR is safe to merge with minimal risk of breaking existing functionality
  • Score reflects well-structured code following existing patterns, proper cleanup of resources, and non-breaking changes to existing components
  • Pay attention to the dynamic styling logic in not-found.tsx to ensure it works correctly across different brand configurations

2 files reviewed, 2 comments

Edit Code Review Bot Settings | Greptile

}
}
checkCustomBrand()
window.addEventListener('resize', checkCustomBrand)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Resize event listener seems unnecessary for brand color detection - brand colors don't typically change on window resize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants