Improvement(sharepoint): added more operations in sharepoint #1369
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR adds comprehensive SharePoint list manipulation capabilities to the existing SharePoint integration. The changes introduce three new tools - get_list, create_list, and update_list - that enable users to perform CRUD operations on SharePoint lists through the workflow system.
The implementation extends the SharePoint block with new operations and form fields, adds the necessary OAuth scopes (Sites.Manage.All) for list management permissions, and creates dedicated tool configurations following the established patterns in the codebase. The get_list tool supports listing all lists in a site, retrieving specific list metadata, and fetching list items with pagination. The create_list tool enables programmatic list creation with custom column definitions via JSON. The update_list tool allows modifying list items while filtering out read-only system fields.
All three tools integrate with the existing Microsoft Graph API authentication infrastructure and follow the same architectural patterns as other tools in the registry. The changes include proper type definitions in the SharePoint types file, extending the existing interfaces with new data structures for lists, columns, and list items. The SharePoint block UI is enhanced with conditional field display based on the selected operation, supporting the different parameter requirements for each list operation.
Confidence score: 2/5
- This PR has significant implementation issues that could cause runtime failures and require careful review
- Score reflects multiple critical bugs including undefined parameter references, missing error handling, and type safety issues across several files
- Pay close attention to
get_list.ts,update_list.ts, andsharepoint.tswhich contain the most problematic code patterns
8 files reviewed, 12 comments
| finalUrl: finalItemsUrl, | ||
| siteId, | ||
| listId: params.listId, | ||
| listTitle: params.listTitle, |
There was a problem hiding this comment.
logic: Logging undefined listTitle parameter that doesn't exist in schema.
…ioai#1369) * added list tools * not working yet * improved read and create * added scopes * updated sharepoint tools * added greptile comments --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>
Summary
Add list manipulation in sharepoint (get list, create list, update list)
Type of Change
Testing
Tested create list, read list, and update list
Checklist
Screenshots/Videos