[patch, test] md5 generates a different output to md5sum #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of `md5sum somefile.txt`: ``` a4d518904c07e3e75fa612890e5c813 somefile.txt ``` Output of `md5 somefile.txt`: ``` MD5 (somefile.txt) = a4d518904c07e3e75fa612890e5c813 ``` The way the test works, is they take the first value from the file, which is not the hash value in case of `md5`. Fix is to run `md5 -r somefile.txt` which outputs: ``` a4d518904c07e3e75fa612890e5c813 somefile.txt ```
SGSSGene
force-pushed
the
fix/macos-md5sum
branch
from
69a12e2 to
dbc4d87
Compare
sarahet
approved these changes
Nov 8, 2022
Member
sarahet
left a comment
sarahet
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of
md5sum somefile.txt:Output of
md5 somefile.txt:The way the test works, is they take the first value from the file, which is not the hash value in case of
md5.Fix is to run
md5 -r somefile.txtwhich outputs: