Skip to content

[cli] change defaults, add profiles #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
h-2 wants to merge 1 commit into from
Closed

[cli] change defaults, add profiles #194

h-2 wants to merge 1 commit into from

Conversation

@h-2
Copy link
Member

@h-2 h-2 commented Oct 28, 2022 •
edited
Loading

  • adds profiles
  • changes default AR to Li10
  • changes default search-parameters
  • makes min-bit-score default and deactivates max-evalue default

@h-2
Copy link
Member Author

h-2 commented Oct 28, 2022

@sarahet This has undergone almost no testing, but feel free to integrate it into other branches and/or PRs.

h-2
h-2 commented Oct 29, 2022
View reviewed changes
src/search_options.hpp
options.searchOpts.maxSeedDist = 0;
}
}
else
Copy link
Member Author

@h-2 h-2 Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else
else if (options.profile == "sensitive")

@sarahet
Copy link
Member

sarahet commented Nov 8, 2022

I am currently integrating this into a PR that adapts/adds tests and also (preliminary) nucleotide profiles that we can then agree or disagree on. Will post it later or tomorrow.

@sarahet sarahet mentioned this pull request Nov 18, 2022
Merged
@h-2
Copy link
Member Author

h-2 commented Nov 30, 2022

superseded by #198

@h-2 h-2 closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-2 @sarahet