Skip to content

docs: translate keeping-components-pure #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neighborhood999 merged 50 commits into from
Oct 16, 2023
Merged

docs: translate keeping-components-pure #414

neighborhood999 merged 50 commits into from
Oct 16, 2023

Conversation

@yangvi0158
Copy link
Contributor

@yangvi0158 yangvi0158 commented Aug 16, 2023

Hi, Please let me know if any problem I need to fix.
Thank you :)

@neighborhood999 neighborhood999 mentioned this pull request Aug 21, 2023
Open
@neighborhood999
Copy link
Member

neighborhood999 commented Aug 21, 2023

Hi, Please let me know if any problem I need to fix. Thank you :)

Hi @viboloveyou12,

First, thank you for your contribution. I found @rccj claimed this document to translate😅, but it's okay, and don't worry. If you want to contribute other documents don't forget to leave a comment on #260, I will update the list to avoid this situation.

@yangvi0158
Copy link
Contributor Author

yangvi0158 commented Aug 21, 2023

Oh, I'm so sorry that I didn't notice the issue!
Thank you for reminding me of this, I'll definitely check it and leave a comment next time.🙏

@rccj
Copy link

rccj commented Sep 11, 2023 •
edited
Loading

@neighborhood999 hi, I just noticed this mention now. Please remove me so that @viboloveyou12 can complete this contribution without any concerns. Thank you 🙏. I'm sorry I couldn't complete this task.

neighborhood999
neighborhood999 reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@neighborhood999 neighborhood999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @viboloveyou12 ,

Thank you for your hard work 🙌, I gave you some suggestions and you can take a look.

Let me know if you have any questions about my suggestions; most translation looks good to me; For some terms we can reserve, you can check Glossary.

@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
7420e9b 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
yangvi0158 and others added 9 commits October 10, 2023 20:50
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
bb40ace 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
7810941 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
01ab93b 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
d18e777 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
ca0af85 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
20ceacc 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
f5bccb2 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
f182a12 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
01368a1 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
yangvi0158 and others added 11 commits October 10, 2023 21:00
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
9d41167 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
020d089 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
ddc91e1 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
6d2dece 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
10ce815 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
9ddef5e 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
cd0ff4d 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
5462839 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
d1a2cf3 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
61b0b43 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
2d7f970 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
yangvi0158 and others added 8 commits October 10, 2023 21:08
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
48e4586 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
6ef22ad 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
472b9e5 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
5c20d0a 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
4ff08e7 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
81679c1 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
b507469 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
f373f48 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158
Copy link
Contributor Author

yangvi0158 commented Oct 10, 2023

Hi @neighborhood999 ,
Thanks for your review and suggestions.
I've modified a new version, if there is anything that can be improved please let me know.

Thank you:)

neighborhood999
neighborhood999 reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @viboloveyou12 for helping, most look great to me.

yangvi0158 and others added 12 commits October 11, 2023 11:58
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
7b03927 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
a6a11fb 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
f910aee 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
a99c658 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
9cf5577 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
df24c98 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
bde3e45 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
42cbea3 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
2aacaa9 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
0656467 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
5b2d775 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@yangvi0158 @neighborhood999
Update src/content/learn/keeping-components-pure.md
4982be0 
Co-authored-by: Jie Peng <dean.leehom@gmail.com>
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@neighborhood999 neighborhood999 merged commit f9455ad into reactjs:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neighborhood999 neighborhood999 neighborhood999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yangvi0158 @neighborhood999 @rccj