Skip to content

Conversation

@swsoyee
Copy link
Contributor

@swsoyee swsoyee commented Feb 20, 2021

Just want to make development convenient

Just want to make development convenient
@timelyportfolio timelyportfolio changed the base branch from master to develop February 20, 2021 15:12
@timelyportfolio timelyportfolio merged commit 5259992 into react-R:develop Feb 20, 2021
@timelyportfolio
Copy link
Collaborator

@swsoyee really appreciate the contribution and welcome more. thanks.

@swsoyee swsoyee deleted the patch-2 branch February 20, 2021 15:19
@timelyportfolio
Copy link
Collaborator

Just realized this change does assume that a user has webpack installed as global, but I don't think this is an unreasonable assumption. Also, the docs and vignettes still point to yarn run webpack, so if a user chooses this option, then they likely know what they are doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants