Skip to content

Conversation

@alandipert
Copy link
Collaborator

@alandipert alandipert commented May 10, 2019

This addresses a race condition introduced by combination with renderUI() that manifested in the colorpicker-example demo app; please see the comment in input.js for details.

#29 should be merged first and yarn run webpack should be run after merging this. I didn't run it so as to not conflict with the other PR.

@alandipert alandipert force-pushed the callback-error branch 2 times, most recently from 2e7f26d to cd1f7f2 Compare May 10, 2019 22:05
@alandipert alandipert marked this pull request as ready for review May 10, 2019 22:06
@alandipert alandipert mentioned this pull request May 10, 2019
@alandipert alandipert self-assigned this May 10, 2019
@timelyportfolio
Copy link
Collaborator

timelyportfolio commented May 13, 2019

Glad we are finding all these edge cases and offering full support for all of Shiny options. I was not aware of this one either. Instead I always handled with debounce or throttle on the R side. Thanks!

@timelyportfolio timelyportfolio merged commit 5e5b55e into master May 13, 2019
@timelyportfolio timelyportfolio deleted the callback-error branch May 13, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants