Skip to content

Migrate tsan config_setting to new unified constraint. #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akrieger wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate tsan config_setting to new unified constraint. #16528

akrieger wants to merge 2 commits into from
+2 −2

Conversation

@akrieger
Copy link
Contributor

@akrieger akrieger commented Jan 9, 2026

Summary: WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709

@akrieger @facebook-github-bot
Migrate asan config_setting to new unified constraint.
1adf529 
Summary: WTTS. Just sed. And then delete the old one.

Reviewed By: aforster

Differential Revision: D88306710
@akrieger @facebook-github-bot
Migrate tsan config_setting to new unified constraint.
ceb846c 
Summary: WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 9, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16528

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit ceb846c with merge base 806c8e8 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link

meta-codesync bot commented Jan 9, 2026

@akrieger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88306709.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2026
8Keep
8Keep approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@8Keep 8Keep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

akrieger added a commit to akrieger/executorch that referenced this pull request Jan 9, 2026
@akrieger @facebook-github-bot
Migrate tsan config_setting to new unified constraint. (pytorch#16528)
5cb21f2 
Summary:

WTTS. Just sed. And then delete the old one.

Reviewed By: rexzhang123

Differential Revision: D88306709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@8Keep 8Keep 8Keep approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akrieger @8Keep