[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Runtime (backend/executor/kernel) #16522
+11
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackend/executor/kernel) Pull Request resolved: #16475 Remove the EXECUTORCH_CLIENTS buck client list visibility gating from runtime targets outside of core. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 2 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - runtime/backend targets - runtime/executor targets - runtime/kernel targets ghstack-source-id: 332138688 @exported-using-ghexport Differential Revision: [D89902033](https://our.internmc.facebook.com/intern/diff/D89902033/)
pytorchbot
requested review from
JacobSzwejbka,
cccclai and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16522
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit dfac039 with merge base 09b5bdb ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #16475 by @GregoryComer
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/167/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/orig
Differential Revision: D89902033
@diff-train-skip-merge