gh-144027: Fix documentation for ignorechars in base64.a85decode() #144028
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not support an ASCII string. Also add more tests.
serhiy-storchaka
added
skip news
needs backport to 3.13
bitdancer
requested changes
Jan 20, 2026
|
|
||
| *ignorechars* should be a :term:`bytes-like object` or ASCII string | ||
| containing characters to ignore | ||
| *ignorechars* should be a byte string containing characters to ignore |
Member
There was a problem hiding this comment.
As noted on the issue, I think bytes-like object is correct here.
| with self.assertRaises(TypeError): | ||
| base64.a85decode(b"a b\nc", ignorechars=" \n") | ||
| with self.assertRaises(TypeError): | ||
| base64.a85decode(b"a b\nc", ignorechars=None) |
Member
There was a problem hiding this comment.
You could also add passing tests for bytearray, array.array, and memoryview here for the ignorechars argument if we want to be complete?
|
When you're done making the requested changes, leave the comment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not support an ASCII string.
Also add more tests.
📚 Documentation preview 📚: https://cpython-previews--144028.org.readthedocs.build/