gh-143756: Avoid borrowed reference in SSL code #143816
Open
+46
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GET_SOCKET() returned a borrowed reference, which was potentially unsafe. Also, refactor out some common code.
ZeroIntensity
approved these changes
Jan 13, 2026
Comment on lines
+777
to
+778
| get_socket(PySSLSocket *obj, PySocketSockObject **out_sock, | ||
| const char *filename, int lineno) |
Member
There was a problem hiding this comment.
It would significantly simplify usage if this were a macro that automatically passed __FILE__ and __LINE__.
Member
There was a problem hiding this comment.
If we have a macro, AFAIR, it expands to something that will not be visually helpful (on the IDE the reported line would mismatch, but I may be wrong here).
So we also could well remove all file/lineno reports and add a description of what we were doing instead, or the involved function.
The file/lineno is only for us to know what happened when someone reports a bug. But the file is likely to always be the same...
picnixz
reviewed
Jan 19, 2026
picnixz
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET_SOCKET() returned a borrowed reference, which was potentially unsafe with free threading. Also, refactor out some common code.