-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-138542: error message is wrong when inspect a custom module #138543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yihong0618
wants to merge
8
commits into
python:main
from
yihong0618:hy/fix_wrong_custom_module_dese_when_inspect
Closed
gh-138542: error message is wrong when inspect a custom module #138543
yihong0618
wants to merge
8
commits into
python:main
from
yihong0618:hy/fix_wrong_custom_module_dese_when_inspect
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
sobolevn
reviewed
Sep 6, 2025
Misc/NEWS.d/next/Library/2025-09-05-23-18-51.gh-issue-138542.hQ9Q04.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: sobolevn <mail@sobolevn.me>
Contributor
Author
|
@sobolevn Thank you very much I learned how to apply suggestions batch! |
sobolevn
reviewed
Sep 7, 2025
Co-authored-by: sobolevn <mail@sobolevn.me>
Contributor
Author
|
@sobolevn Thank you very much |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
reviewed
Sep 7, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
approved these changes
Sep 7, 2025
Member
picnixz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as diff and issues
for build-in module there's a
object.__spec__this patch make the error message better.