Migrate Version URL Parser to TypeScript #3776
Open
+29
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes : #3761
This PR migrates the version URL parsing logic to TypeScript as part of the ongoing TS conversion effort.
Changes Made
parseUrlParamsand helpers to TypeScriptvalidateVersion(version: string | null)validateBool(value: string | null, defaultValue: boolean)getNewestVersion(versions: string[])p5Versionsto handle both string and{ version, label }entries safelyRelated Issue
Closes #3761
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3761