[#68702] Project user filter also includes groups and placeholder users #21585
+42
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EinLama
force-pushed
the
bug/68702-project-cf-of-type-user-does-not-display-groups-or-placeholder-users
branch
from
2960687 to
a14ba9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/68702
What are you trying to accomplish?
Remove the type = User restriction on the filter component, so that groups and placeholder users can also be found.
Included some minor drive-by rubocop fixes for neighboring specs.
Screenshots
What approach did you choose and why?
Simply removed the restriction from the base class that only matched on principals of type user. Apart from the project filter, the meetings filter is inheriting from the base class, too. Therefore, this change alters meetings filters – in theory. In practice, there is no user custom field filter for meetings, so this change has no effect on meetings.
Merge checklist