Merge release/17.0 into dev #21583
Closed
Merge release/17.0 into dev #21583
+2,354
−1,485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use danger-variant button with leading icon to make the action less ambiguous. https://community.openproject.org/work_packages/70168
https://community.openproject.org/wp/70290 This fixes the regression introduced in 5ea185e: the `possible_principal_id` was run against the source project instead of the target project, leading to always return something. Fix is to always run `possible_principal_id` against the target project. This was not detected by the unit tests: original tests were taking the first work package of the copied project to check that the user field was nil, assuming the first work package would be the copy of the one having the user field set, but actually the work package was not copied, so another work package is picked and this one has all user fields nil because the original work package has all user fields nil. The test was fixed by explicitly getting the copied work package using the subject of the original work package, and failing if the copied work package is not found.
And remove the usage of `project_copy.work_packages[0]` which can lead to false positives 😱 when there are more than one element copied.
…-copy-work-packages-being-assigned-to-if-members-are-not-copied [70290] Project copy nilifies user fields if members are excluded
…creen-overflow-on-mobile [69677] Project creation modal: Screen overflow on mobile
Use "Download" rather than "Sign Out" icon. https://community.openproject.org/work_packages/70184
…eadcrumbs-not-clickable-starting-with-grand-parents [69640] Workpackage hierarchy breadcrumbs not clickable starting with grand parents
…tion-icon [#70168] Fix Session revocation button
…for programs and portfolios
[#70184] Fix Export icon in Projects list menu
* [#69454] New widgets dashboard for the overview page https://community.openproject.org/work_packages/69454 [#69454] New widgets dashboard for the overview page https://community.openproject.org/work_packages/69454 * fix broken links * fix links to moved pages and changed headers * fix links to moved pages * Apply suggestions from code review Co-authored-by: Henriette Darge <h.darge@openproject.com> * fix the members widget description --------- Co-authored-by: as-op <a.sandorf@openproject.com> Co-authored-by: Andrej <77627197+as-op@users.noreply.github.com> Co-authored-by: Henriette Darge <h.darge@openproject.com>
…n-enabling-email-notifications-for-a-series [#70178] Missing notification when enabling email notifications for a series
rspec ./spec/features/admin/settings/project_custom_fields/attribute_help_text_spec.rb:204
Without this commit, unwanted fields would still show up in the creation form, as the NewProjectService will always create the mappings. But it will only remove unwanted mappings after successfully persisting the project. This does not happen if there are errors (e.g. a required field has no value). Since the field should never have been activated in the first place, it is expected to have no value. Still, this validation errors prohibits saving - and thus the errornous field is never cleaned up.
... even if it is identical to the default value
) Do not trigger basic auth pop-up on signout See: #18952 https://community.openproject.org/wp/69643
…low (#21556) move page header to the content header
…fle-icon [70244] Waffle icon is too small
* Dont check the first item in the list of search box, show the list items for screen reader * highlight the WP if the full id is added and change aria-live message * feature spec for live region * use the global live region for announcing changes * set void for promises
…project home page (#21539) Omit the word "project" from the widget titles since they also apply for programs and portfolios
openprojectci
added
the
create-merge-release-into-dev-pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by GitHub action
Replaces #21581