[#70183] Fix Work Package Export dialog resizing on switching format #21547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Work Package Export dialog resizing issue when switching between different export formats (CSV, PDF, XLS) by changing the dialog size from :xlarge to :medium_portrait.
Key changes:
- Changed the
Primer::Alpha::Dialogsize parameter from:xlargeto:medium_portraitto prevent the dialog from resizing when users switch between export formats
Contributor
|
Hi @myabc Screen.Recording.2026-01-06.at.11.22.31.movBut I think it should be discussed with designers. cc/ @psatyal , @marcalcobe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/70183
What are you trying to accomplish?
Fixes Work Package Export dialog resizing by changing size to
medium_portrait.Screenshots
What approach did you choose and why?
This PR makes the Export dialog portrait - which IMO looks better. An alternative strategy could be to add a minimum height, but I think that probably warrants discussion with UX/UI team first.
Merge checklist