Skip to content

[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
caiolima wants to merge 160 commits into
base: v25.x-staging
Choose a base branch
from
Open

[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

caiolima wants to merge 160 commits into from
+172,975 −73,302

Conversation

@caiolima
Copy link
Contributor

@caiolima caiolima commented Nov 21, 2025

As noted by @targos in #60429 (comment), the implementation of total_allocated_bytes changes the ABI. This PR changes original V8 implementation to a version where there's no addition of HeapStatistics::total_allocated_bytes_ to V8's HeapStatistics, and instead we get such values using Isolate::GetTotalAllocatedBytes. This also changes code introduced by #60573 to use this new API on either v8.getHeapStatistics() and Worker::GetHeapStatistics. The goal here is to make total_allocated_bytes back portable to previous versions, but keeping the v8.getHeapStatistics() API stable once users transition from v25 to future versions. It also solves the ABI change introduced by https://github.com/nodejs/node/pull/60429/files

There's also a fix on documentation text with missing . and updating the code snippet to include total_allocated_bytes on output.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. labels Nov 21, 2025
This was referenced Nov 21, 2025
Open
Merged
RafaelGSS
RafaelGSS approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70277/

@targos
Revert "doc, assert: correct order of changes entries"
c1cec7a 
This reverts commit 8a6de38.

PR-URL: nodejs#60774
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@caiolima
Copy link
Contributor Author

caiolima commented Nov 25, 2025

Hi all, could someone help me trigger CI again, please?

joyeecheung and others added 17 commits November 27, 2025 10:27
@joyeecheung @targos
src: build v8 tick processor as built-in source text modules
b54fb43 
Instead of polyfilling it with vm.SourceTextModule,
use a built-in source text module loader so that we can
also build the code cache for it at build tiem to
embed the code cache for them in the binary.

Drive-by: instead of inferring how to compile a particular
built-in at run time, do the inferring at build time,
so the function-based built-ins can be compiled using
parameters quickly looked up from a static map, and
the builtins that should be compiled as source text
modules are known internally based on extension in
the source code (at run time, the extensions are all
removed).

PR-URL: nodejs#60518
Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@aduh95 @targos
test: ensure assertions are reached on more tests
6477ca8 
PR-URL: nodejs#60641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@joyeecheung @targos
test: split test-runner-run-watch.mjs
313f0dc 
This test contains too many independent test cases and as a
result, marking it as flaky on all major platforms means
actual regressions could be covered up, and it's constantly
making the CI orange and requires extra resuming on the
flaked platforms which is still not great. Split it into
individual files so that the actual flake can be identified
out of the monolith.

PR-URL: nodejs#60653
Refs: nodejs#54534
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@kxxt @targos
test: fix test-strace-openat-openssl for RISC-V
851edf2 
Recent architectures like RISC-V does not support open syscall,
which will cause strace to fail and thus test failure.

    AssertionError [ERR_ASSERTION]: strace: invalid system call 'open'

This patch disables tracing open syscall for RISC-V in the test to fix
the test failure.

PR-URL: nodejs#60588
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@kxxt @targos
test: limit the concurrency of WPTRunner for RISC-V
88f4ed9 
For riscv64, the most commonly supported paging mode is sv39, which
allocates 256GiB of virtual address space for the user space. However,
due to trap handler security mechanism in V8, creating a wasm memory
will cost 8GiB of continuous virtual address space. In a fresh node
repl, I could only create 27 WebAssembly.Memory instances. When the
virtual address space is more fragmented, it is worse.

The wpt tests are randomly failing on riscv64 due to insufficient
virtual address space to create wasm memories. This PR fixes it by
limiting the concurrency of the WPTRunner to prevent the tests from
creating too many wasm memories.

PR-URL: nodejs#60591
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot @targos
tools: update gyp-next to 0.21.0
70d3cbd 
PR-URL: nodejs#60645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@nodejs-github-bot @targos
deps: update simdjson to 4.2.1
d5cfe2a 
PR-URL: nodejs#60644
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@joyeecheung @targos
benchmark: use typescript for import cjs benchmark
4809273 
The original benchmark uses a not very realistic fixture (it has
a huge try-catch block that would throw on the first line and then
export at the end, hardly representative of real-world code).
Also, it measures the entire import including evaluation, not just
parsing. This updates the name to import-cjs to be more accurate,
and use the typescript.js as the fixture which has been reported
to be slow to import, leading users to use require() to work around
the peformance impact. It splits the measurement into two different
types: parsing CJS for the first time (where the overhead of
loading the lexer makes a difference) and parsing CJS after the
lexer has been loaded.

PR-URL: nodejs#60663
Refs: nodejs#59913
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@joyeecheung @targos
esm: use wasm version of cjs-module-lexer
bf27b85 
The synchronous version has been available since 1.4.0.

PR-URL: nodejs#60663
Refs: nodejs#59913
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Renegade334 @targos
doc: domain.add() does not accept timer objects
712f944 
PR-URL: nodejs#60675
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@aduh95 @targos
tools: update x64 macOS runner
d915dfa 
PR-URL: nodejs#60676
Refs: actions/runner-images#13046
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@artsiom-malakhau @targos
doc: fix incorrect slh-dsa oids in crypto.md
40f9976 
Correct wrong object identifiers listed for slh-dsa algorithms in
doc/api/crypto.md. the valid range is from id-slh-dsa-sha2-128s
(2.16.840.1.101.3.4.3.20) through id-slh-dsa-shake-256f
(2.16.840.1.101.3.4.3.31), as defined in the ietf
draft-ietf-lamps-x509-slhdsa.

Fixes: nodejs#60680
Refs: https://datatracker.ietf.org/doc/draft-ietf-lamps-x509-slhdsa/
PR-URL: nodejs#60681
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@ChALkeR @targos
test: fix test-buffer-zero-fill-cli to be effective
4eeb0d1 
PR-URL: nodejs#60623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@KevinEady @targos
node-api: support SharedArrayBuffer in napi_create_dataview
5ed8d03 
PR-URL: nodejs#60473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@panva @targos
lib: refactor JWK import PQC support check
eb44d07 
PR-URL: nodejs#60586
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ChALkeR @targos
buffer: let Buffer.of use heap
c890668 
PR-URL: nodejs#60503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 @targos
doc: add info about renamed flag in cli.md
8a266d1 
PR-URL: nodejs#60690
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
dependabot bot and others added 11 commits December 5, 2025 14:17
@dependabot @targos
meta: bump github/codeql-action from 4.31.3 to 4.31.6
e414669 
Bumps [github/codeql-action](https://github.com/github/codeql-action)
from 4.31.3 to 4.31.6.

- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60926
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@dependabot @targos
meta: bump actions/setup-python from 6.0.0 to 6.1.0
d130e8f 
Bumps [actions/setup-python](https://github.com/actions/setup-python)
from 6.0.0 to 6.1.0.

- [Release notes](https://github.com/actions/setup-python/releases)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60927
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@hybrist @targos
module: allow subpath imports that start with #/
99ab516 
It's a common ecosystem pattern to map a source root directory to
`@/` but it requires special tooling support. This turns `#/*` into
a more realistic alternative for that pattern.

PR-URL: nodejs#60864
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@dependabot @targos
tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc
012bac1 
Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1.
- [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases)
- [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-hast
  dependency-version: 13.2.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mertcanaltin @targos
src: implement Windows-1252 encoding support and update related tests
abdccc0 
PR-URL: nodejs#60893
Fixes: nodejs#60888
Fixes: nodejs#59515
Fixes: nodejs#56542
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@LiviaMedeiros @targos
http2,zlib: prefer call() over apply() if argument list is not array
2dcb1d8 
PR-URL: nodejs#60834
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS @targos
test: improve config-file permission test coverage
63eb50a 
Refs: nodejs#60746 (review)
PR-URL: nodejs#60929
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mag123c @aduh95
esm: improve error messages for ambiguous module syntax
685259c 
PR-URL: nodejs#60376
Fixes: nodejs#60322
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Mohit-Raj-Saxena @aduh95
doc: add File modes cross-references in fs methods
a8fe6c3 
Adds links to the File modes section from fsPromises.open(),
fsPromises.mkdir(), and fs.mkdir() to improve discoverability
of file permission documentation.

PR-URL: nodejs#60286
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95
tools: add some options and comments to shell.nix
747fd11 
PR-URL: nodejs#60911
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95
test: skip tests not passing without NODE_OPTIONS support
eb0705a 
PR-URL: nodejs#60912
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70419/

pthier and others added 2 commits December 10, 2025 10:29
@RafaelGSS
deps: V8: cherry-pick 72b0e27bd936
9149ba4 
Original commit message:

    [regexp] Fix modifiers for ChoiceNodes

    Each alternative might modify flags when their sub-graph is emitted.
    We need to restore flags to the value at the beginning of a ChoiceNode
    for each alternative.

    Drive-by: Move regexp-modifiers test out of harmony/

    Fixed: 447583670
    Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#102838}

Refs: v8/v8@72b0e27
Refs: nodejs#60030
PR-URL: nodejs#60706
Backport-PR-URL: nodejs#60706
@Renegade334 @RafaelGSS
lib: do not provide an empty Proxy from localStorage getter
c57a40c 
PR-URL: nodejs#60776
Refs: nodejs#60303
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@caiolima
Copy link
Contributor Author

caiolima commented Dec 17, 2025

I'm getting permission errors to look what is failing on CI. Probably it already expired. Does any of you have permission to see what's failing?

@caiolima caiolima force-pushed the backport-60573-to-v25 branch from 5669bd4 to f6b05d5 Compare January 6, 2026 13:59
@aduh95 aduh95 requested a review from a team as a code owner January 9, 2026 23:32
@RafaelGSS RafaelGSS force-pushed the v25.x-staging branch 2 times, most recently from 9f2e230 to 65696e4 Compare January 15, 2026 16:41
@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - tools: fix linter warning in `test-shared.yml`
   ⚠  - doc: correct concurrency wording in test() documentation
   ⚠  - build: fix OpenSSL version parsing for OpenSSL < 3
   ⚠  - test_runner: simplify code and make it more consistent
   ⚠  - repl: tab completion targets `` instead of `new `
   ⚠  - tools: bump js-yaml from 4.1.0 to 4.1.1 in /tools/lint-md
   ⚠  - deps: update brotli to 1.2.0
   ⚠  - deps: upgrade npm to 11.6.3
   ⚠  - tools: dump config.gypi as json
   ⚠  - lib: prefer `call()` over `apply()` if argument list is not array
   ⚠  - src: rename config file testRunner to test
   ⚠  - src: add test flag to config file
   ⚠  - src: add permission flag to config file
   ⚠  - doc: fix webstorage config file property
   ⚠  - src: implicitly enable namespace in config
   ⚠  - doc: keep sidebar module visible when navigating docs
   ⚠  - deps: update sqlite to 3.51.0
   ⚠  - deps: add temporal_rs 0.1.0
   ⚠  - build: add temporal_capi gyp
   ⚠  - test: add basic temporal presence check
   ⚠  - build: ignore built-in temporal when building with shared lib
   ⚠  - url: remove array.reduce usage
   ⚠  - test_runner: fix line feed escaping in JUnit
   ⚠  - test: use `RegExp.escape` to improve test reliability
   ⚠  - doc: add additional codemods for deprecation
   ⚠  - test: prefer major GC in cppgc-object teardown
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - test: ensure assertions are reached on more tests
   ⚠  - tools: add temporal updater
   ⚠  - test: replace deprecated regex test assertions in http trailers test
   ⚠  - doc: add fullName property to SuiteContext
   ⚠  - test: add lint rule to forbid use of `assert.ok(/regex/.test(…))`
   ⚠  - events: repurpose `events.listenerCount()` to accept EventTargets
   ⚠  - src: mark unused private field as such
   ⚠  - src: simply uint32 to string as it must not fail
   ⚠  - lib: add lint rules for reflective function calls
   ⚠  - test: ensure assertions are reached on all tests
   ⚠  - test: fix debug test crashes caused by sea tests
   ⚠  - doc: mark module.register as active development
   ⚠  - util: safely inspect getter errors whose message throws
   ⚠  - node-api: fix data race and use-after-free in napi_threadsafe_function
   ⚠  - src: handle indexed properties in `process.env`
   ⚠  - deps: upgrade npm to 11.6.4
   ⚠  - doc: fix typos in changelogs
   ⚠  - doc: correct 'event handle' to 'event handler' in Utf8Stream drop event
   ⚠  - test: skip failing tests when compiled without amaro
   ⚠  - doc: update debuglog examples to use 'foo-bar' instead of 'foo'
   ⚠  - src: use static_cast instead of C-style cast
   ⚠  - test: fix embedtest in debug windows
   ⚠  - doc: correct spelling in BUILDING.md
   ⚠  - doc: replace column with columnNumber in example of `util.getCallSites`
   ⚠  - deps: update corepack to 0.34.5
   ⚠  - test: use `assert.match` for non-literal regexp tests
   ⚠  - doc: show the use of string expressions in the SQLTagStore example
   ⚠  - lib,test: fix jsdoc comments
   ⚠  - test: lint more `assert(regexp.test(...))` cases
   ⚠  - doc: clarify fileURLToPath security considerations
   ⚠  - util: improve textencoder encodeInto performance
   ⚠  - src: handle DER decoding errors from system certificates
   ⚠  - tools: don't fetch V8 deps in the source tree
   ⚠  - build: run embedtest with node_g when BUILDTYPE=Debug
   ⚠  - test: update WPT for WebCryptoAPI to 1e4933113d
   ⚠  - deps: update zlib to 1.3.1-63d7e16
   ⚠  - deps: update sqlite to 3.51.1
   ⚠  - deps,src: prepare for cpplint update
   ⚠  - tools: disable some new cpplint rules before update
   ⚠  - tools: update cpplint to 2.0.2
   ⚠  - tools: refloat 10 Node.js patches to cpplint.py
   ⚠  - src: fix off-thread cert loading in bundled cert mode
   ⚠  - test: skip SEA inspect test if inspector is not available
   ⚠  - tools: update ESLint dependencies
   ⚠  - tools: remove deprecated ESLint plugins
   ⚠  - tools: replace deprecated eslint-plugin-markdown
   ⚠  - doc: add missing `zstd` to mjs example of zlib
   ⚠  - benchmark: fix incorrect base64 input in byteLength benchmark
   ⚠  - tools: run tests `--without-amaro` on test-shared macOS
   ⚠  - stream: fix isErrored/isWritable for WritableStreams
   ⚠  - tools: enforce trailing commas in `test/sequential`
   ⚠  - tools: enforce trailing commas in `test/es-module`
   ⚠  - tools: ignore more paths in GHA CI
   ⚠  - util: assert getCallSites does not invoke Error.prepareStackTrace
   ⚠  - meta: bump peter-evans/create-pull-request from 7.0.8 to 7.0.9
   ⚠  - meta: bump actions/checkout from 5.0.1 to 6.0.0
   ⚠  - meta: bump github/codeql-action from 4.31.3 to 4.31.6
   ⚠  - meta: bump actions/setup-python from 6.0.0 to 6.1.0
   ⚠  - module: allow subpath imports that start with `#/`
   ⚠  - tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc
   ⚠  - src: implement Windows-1252 encoding support and update related tests
   ⚠  - http2,zlib: prefer `call()` over `apply()` if argument list is not array
   ⚠  - test: improve config-file permission test coverage
   ⚠  - esm: improve error messages for ambiguous module syntax
   ⚠  - doc: add File modes cross-references in fs methods
   ⚠  - tools: add some options and comments to `shell.nix`
   ⚠  - test: skip tests not passing without `NODE_OPTIONS` support
   ⚠  - deps: V8: cherry-pick 72b0e27bd936
   ⚠  - lib: do not provide an empty Proxy from localStorage getter
   ⚠  - v8: changing total_allocated_bytes to avoid ABI changes
   ⚠  - increasing node embedder number
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/21052182155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.