Skip to content

Conversation

@shigeki
Copy link
Contributor

@shigeki shigeki commented Apr 11, 2018

Do not terminate vcbuild.bat even if nasm is not found on Windows.
In that case, configure emits a warning message and continues to build
Node.js with openssl_no_asm option enabled.

This cannot be checked with CI for nasm was already installed.
The following the output of vcbuild.bat on my Windows after uninstalling nasm.

CC @joaocgreis and @nodejs/build

Looking for Python 2.x
Looking for NASM
Looking for Visual Studio 2017
Found MSVS version 15.0
configure  --dest-cpu=x64
WARNING: No acceptable ASM compiler found!
         Please make sure you have installed nasm from http://www.nasm.us
         and refer BUILDING.md.
WARNING: openssl_no_asm is enabled due to missed or old assembler.
            Please refer BUILDING.md
creating icu_config.gypi
* Using ICU in deps/icu-small
creating icu_config.gypi
{ 'target_defaults': { 'cflags': [],
                       'default_configuration': 'Release',
                       'defines': [],
                       'include_dirs': [],
                       'libraries': []},
  'variables': { 'asan': 0,
                 'coverage': 'false',
                 'debug_http2': 'false',
                 'debug_nghttp2': 'false',
                 'force_dynamic_crt': 0,
                 'host_arch': 'x64',
                 'icu_data_in': '..\\..\\deps/icu-small\\source/data/in\\icudt61l.dat',
                 'icu_endianness': 'l',
                 'icu_gyp_path': 'tools/icu/icu-generic.gyp',
                 'icu_locales': 'en,root',
                 'icu_path': 'deps/icu-small',
                 'icu_small': 'true',
                 'icu_ver_major': '61',
                 'nasm_version': 0,
                 'node_byteorder': 'little',
                 'node_debug_lib': 'false',
                 'node_enable_d8': 'false',
                 'node_enable_v8_vtunejit': 'false',
                 'node_install_npm': 'true',
                 'node_module_version': 62,
                 'node_no_browser_globals': 'false',
                 'node_prefix': '/usr/local',
                 'node_release_urlbase': '',
                 'node_shared': 'false',
                 'node_shared_cares': 'false',
                 'node_shared_http_parser': 'false',
                 'node_shared_libuv': 'false',
                 'node_shared_nghttp2': 'false',
                 'node_shared_openssl': 'false',
                 'node_shared_zlib': 'false',
                 'node_tag': '',
                 'node_target_type': 'executable',
                 'node_use_bundled_v8': 'true',
                 'node_use_dtrace': 'false',
                 'node_use_etw': 'true',
                 'node_use_openssl': 'true',
                 'node_use_perfctr': 'true',
                 'node_use_v8_platform': 'true',
                 'node_without_node_options': 'false',
                 'openssl_fips': '',
                 'openssl_no_asm': 1,
                 'shlib_suffix': 'so.62',
                 'target_arch': 'x64',
                 'v8_enable_gdbjit': 0,

Fixes: #19918

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [x ] commit message follows commit guidelines

Do not terminate vcbuild.bat even if nasm is not found on Windows.
In that case, configure emits a warning message and continues to build
Node.js with openssl_no_asm option enabled.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Apr 11, 2018
@bzoz
Copy link
Contributor

bzoz commented Apr 11, 2018

@bzoz
Copy link
Contributor

bzoz commented Apr 11, 2018

Since this unbreaks master, I think we should fast-track this.

@bzoz bzoz added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 11, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2018
@rvagg
Copy link
Member

rvagg commented Apr 11, 2018

I'm +1 on @bnoordhuis' suggestion of making it fail unless you explicitly opt out #19918 (comment)

@rvagg
Copy link
Member

rvagg commented Apr 11, 2018

@bzoz master isn't broken, it's just giving a message that inconsistent with its behaviour. It's inconvenient and confusing for users but for those building from source we should be giving a stronger recommendation to grab nasm.

shigeki added a commit that referenced this pull request Apr 12, 2018
Instead of automatically falling back to openssl_no_asm with warning
if no nasm is found during build on Windows, this stops vcbuild.bat
and requires users to specify openssl_no_asm option explicitly.

Fixes: #19918
PR-URL: #19943
Refs: #19930
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@shigeki
Copy link
Contributor Author

shigeki commented Apr 12, 2018

Closing by #19943.

@shigeki shigeki closed this Apr 12, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
Instead of automatically falling back to openssl_no_asm with warning
if no nasm is found during build on Windows, this stops vcbuild.bat
and requires users to specify openssl_no_asm option explicitly.

Fixes: #19918
PR-URL: #19943
Refs: #19930
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: default building of master is broken on Windows without NASM

5 participants