-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
build, tools, win: enable build without nasm #19930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not terminate vcbuild.bat even if nasm is not found on Windows. In that case, configure emits a warning message and continues to build Node.js with openssl_no_asm option enabled.
bzoz
approved these changes
Apr 11, 2018
Contributor
Contributor
|
Since this unbreaks master, I think we should fast-track this. |
Member
|
I'm +1 on @bnoordhuis' suggestion of making it fail unless you explicitly opt out #19918 (comment) |
Member
|
@bzoz master isn't broken, it's just giving a message that inconsistent with its behaviour. It's inconvenient and confusing for users but for those building from source we should be giving a stronger recommendation to grab nasm. |
4 tasks
shigeki
added a commit
that referenced
this pull request
Apr 12, 2018
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly. Fixes: #19918 PR-URL: #19943 Refs: #19930 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Contributor
Author
|
Closing by #19943. |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Instead of automatically falling back to openssl_no_asm with warning if no nasm is found during build on Windows, this stops vcbuild.bat and requires users to specify openssl_no_asm option explicitly. Fixes: #19918 PR-URL: #19943 Refs: #19930 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
install
Issues and PRs related to the installers.
tools
Issues and PRs related to the tools directory.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not terminate vcbuild.bat even if nasm is not found on Windows.
In that case, configure emits a warning message and continues to build
Node.js with openssl_no_asm option enabled.
This cannot be checked with CI for
nasmwas already installed.The following the output of
vcbuild.baton my Windows after uninstallingnasm.CC @joaocgreis and @nodejs/build
Fixes: #19918
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes