Skip to content

Conversation

@gabrielschulhof
Copy link
Contributor

Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: #797

Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs#797
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NickNaso NickNaso mentioned this pull request Sep 16, 2020
6 tasks
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 51e25f7 into nodejs:master Sep 17, 2020
Superlokkus pushed a commit to Superlokkus/node-addon-api that referenced this pull request Nov 20, 2020
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs#797
@gabrielschulhof gabrielschulhof deleted the remove-doc-file branch February 1, 2021 16:39
@gabrielschulhof gabrielschulhof restored the remove-doc-file branch February 1, 2021 16:40
@gabrielschulhof gabrielschulhof deleted the remove-doc-file branch March 7, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we need doc/working_with_javascript_values.md?

3 participants