Fix wrap/unwrap of objects also inheriting from non-ObjectWrap #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
approved these changes
May 27, 2020
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM. @davedoesdev thanks for the fix and the test case.
Member
|
@nodejs/n-api would be great to get one more review before I land this. |
mhdawson
pushed a commit
that referenced
this pull request
Jun 8, 2020
- fix wrap/unwrap of objects inheriting from non-ObjectWrap PR-URL: #732 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Member
|
Landed as ba7ad37 |
Closed
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
- fix wrap/unwrap of objects inheriting from non-ObjectWrap PR-URL: nodejs/node-addon-api#732 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
- fix wrap/unwrap of objects inheriting from non-ObjectWrap PR-URL: nodejs/node-addon-api#732 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
- fix wrap/unwrap of objects inheriting from non-ObjectWrap PR-URL: nodejs/node-addon-api#732 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
- fix wrap/unwrap of objects inheriting from non-ObjectWrap PR-URL: nodejs/node-addon-api#732 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectWrapmethods need to cast toT*otherwisethisgets set wrongly when unwrapping.Included test fails without the fix because the object is unwrapped to the wrong address.
Tested using gcc 9.3.0