src: fix use of Reference with typed arrays #726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#702 Previously calling Value() on a Reference for a TypedArray that the enderlying object had been collected would result in an error due to a failure in creating the return value. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
Member
Author
|
@nodejs/addon-api if you get a chance please review. Fairly small change. |
Member
Author
|
@gabrielschulhof, @legendecas, @NickNaso any chance you can review? |
legendecas
approved these changes
May 22, 2020
mhdawson
added a commit
that referenced
this pull request
Jun 9, 2020
Fixes: #702 Previously calling Value() on a Reference for a TypedArray that the enderlying object had been collected would result in an error due to a failure in creating the return value. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #726 Fixes: #702 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
Author
|
Landed as 36e1af9 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fixes: nodejs/node-addon-api#702 Previously calling Value() on a Reference for a TypedArray that the enderlying object had been collected would result in an error due to a failure in creating the return value. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs/node-addon-api#726 Fixes: nodejs/node-addon-api#702 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fixes: nodejs/node-addon-api#702 Previously calling Value() on a Reference for a TypedArray that the enderlying object had been collected would result in an error due to a failure in creating the return value. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs/node-addon-api#726 Fixes: nodejs/node-addon-api#702 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fixes: nodejs/node-addon-api#702 Previously calling Value() on a Reference for a TypedArray that the enderlying object had been collected would result in an error due to a failure in creating the return value. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs/node-addon-api#726 Fixes: nodejs/node-addon-api#702 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fixes: nodejs/node-addon-api#702 Previously calling Value() on a Reference for a TypedArray that the enderlying object had been collected would result in an error due to a failure in creating the return value. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs/node-addon-api#726 Fixes: nodejs/node-addon-api#702 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #702
Previously calling Value() on a Reference for a TypedArray
that the enderlying object had been collected would result
in an error due to a failure in creating the return value.
Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com