fix: handle match_mask == 0 in NEON ctzll to avoid undefined behavior #83
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all 16 bytes match the allowed range,
match_maskbecomes 0 after the bitwise NOT. Calling__builtin_ctzll(0)is undefined behavior.The code expects
match_len == 16when all bytes match (so the branch is skipped andp += 16continues the loop), but this relied onctzll(0)returning 64, which is not guaranteed.Example panic on macOS ARM64:
Fix by explicitly checking for
match_mask == 0and settingmatch_len = 16.Related: lalinsky/dusty#14