Skip to content

Conversation

@ozyx
Copy link
Contributor

@ozyx ozyx commented Dec 13, 2023

Closes #7297

Describe your changes:

Define main in package.json so we can import openmct from 'openmct' out of the box!

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested a review from unlikelyzero December 13, 2023 23:53
@deploysentinel
Copy link

deploysentinel bot commented Dec 13, 2023

Current Playwright Test Results Summary

✅ 164 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/14/2023 12:07:44am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: c2ddaa2

Started: 12/13/2023 11:56:22pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
0% (0) 0 / 27 runs
failed over last 7 days
55.56% (15) 15 / 27 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 15 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/14/2023 12:07:44am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: c2ddaa2

Started: 12/13/2023 11:55:39pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 23 runs
failed over last 7 days
8.70% (2) 2 / 23 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #7298 (c2ddaa2) into master (902ed02) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7298      +/-   ##
==========================================
+ Coverage   55.94%   55.98%   +0.03%     
==========================================
  Files         655      655              
  Lines       26297    26297              
  Branches     2541     2541              
==========================================
+ Hits        14713    14723      +10     
+ Misses      10878    10867      -11     
- Partials      706      707       +1     
Flag Coverage Δ
e2e-full 41.91% <ø> (+0.06%) ⬆️
e2e-stable 58.44% <ø> (+0.07%) ⬆️
unit 49.26% <ø> (-0.01%) ⬇️

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902ed02...c2ddaa2. Read the comment docs.

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 14, 2023
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Dec 14, 2023
@unlikelyzero unlikelyzero merged commit 800b03a into master Dec 14, 2023
@unlikelyzero unlikelyzero deleted the ozyx-patch-1 branch December 14, 2023 13:50
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:maintenance tests, chores, or project maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package.json should define the main entry point for CJS

3 participants