Skip to content

Conversation

@XiaoMigros
Copy link
Contributor

The 'Maximum value' value is currently falsely displayed as a spatium value in the UI, even though internally it's treated as a double.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup requested review from a user and cbjeukendrup July 24, 2025 19:12
@ghost
Copy link

ghost commented Jul 25, 2025

Might it not be even nicer to express this in degrees (horizontal being 0°), perhaps?

@XiaoMigros
Copy link
Contributor Author

The difficulty with using degrees is that we would encounter issues using the arrow handles to change the value, as internally the value is stored as a slope. Unless we apply a clever conversion (which would involve more intrusive code changes to the already messy dialog), the step sizes would be result inconsistent, seemingly random numbers.
The other solution would be to change the internal engraving system to use degrees, and apply a conversion when importing older scores. If I could choose, that would be my preferred solution, since using degrees makes more sense. That would mean a couple of lines of added code in the style import code, but leave the dialog pretty much untouched.

@bkunda
Copy link

bkunda commented Oct 23, 2025

@XiaoMigros I think we're in agreement that the % is better than the spatium value. At this stage, I'm not sure it's worth the effort to try and adopt degrees (although this is obviously the most correct option) given the issues it would present for maintaining compatibility.

@cbjeukendrup will give it a quick rebase so we can test it. Many thanks!

@ghost ghost removed their request for review November 27, 2025 09:17
@cbjeukendrup cbjeukendrup merged commit 3097f44 into musescore:master Jan 9, 2026
12 checks passed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants