Skip to content

[Security] Harden CLI dev command against injection on Windows #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

[Security] Harden CLI dev command against injection on Windows #1904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f4dba9
[Security] Fix potential command injection on Windows in CLI dev command
RinZ27 Jan 17, 2026
b6a0419
Switch from shlex.quote to subprocess.list2cmdline for Windows support.
RinZ27 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/mcp/cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,16 @@ def dev(

# Run the MCP Inspector command with shell=True on Windows
shell = sys.platform == "win32"
cmd_args = [npx_cmd, "@modelcontextprotocol/inspector"] + uv_cmd

if shell:
# On Windows with shell=True, I need to quote arguments to prevent injection
# and join them into a single string, as passing a list with shell=True is unsafe/undefined behavior
# Using list2cmdline as it's the correct way to escape for cmd.exe
cmd_args = subprocess.list2cmdline(cmd_args)

process = subprocess.run(
[npx_cmd, "@modelcontextprotocol/inspector"] + uv_cmd,
cmd_args,
check=True,
shell=shell,
env=dict(os.environ.items()), # Convert to list of tuples for env update
Expand Down
Loading