CmdPal: Icon cache #44538
Open
CmdPal: Icon cache #44538
+1,090
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and extend icon rendering infrastructure to support DPI-aware, theme-responsive, and size-adaptive icon caching. - Refactors`IconBox` to track and respond to theme, scale, and size changes - Adds`scale` property to `SourceRequestedEventArgs` for DPI-aware icon generation - Introduces`AdaptiveCache` with time-based decay for efficient icon reuse - Updates`IconCacheProvider` and `IconCacheService` to support multiple icon sizes (e.g., 20x20, 64x64), scale-aware caching, and robust async loading - `IconCacheService` now decodes bitmap to required size to reduce memory usage - Introduces priority decoding in `IconCacheService` - Extends`IconPathConverter` to accept target size for icon generation - Use jumbo icon cache for hero images in `ShellPage` - Handles null `XamlRoot` safely in `MainWindow` title bar logic - Fixes Tag icon position
jiripolasek
added
the
Product-Command Palette
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Collaborator
|
When you're ready, one or two screenshots would be welcome - where fit. P.S. Me - for one - find your light sarcasm very amusing 😁 |
Member
|
This one's pretty big so I'm gonna hold it for 0.98 |
zadjii-msft
added
the
Don't merge - Hold for release
Collaborator
Author
Definitely! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR implements actual cache in IconCacheService and adds some fixes on top for free.
The good
IconCacheServicenow caches decoded iconsIconCacheServicedecodes bitmaps directly to the required size to reduce memory usageIconBoxnow reacts to theme, DPI scale, and size changes immediatelyAdaptiveCachewith time-based decay to improve icon reuseIconCacheProviderandIconCacheServiceto handle multiple icon sizes and scale-aware cachingIconCacheServicefor more responsive loadingIconPathConverterto support target icon sizesShellPageto use the jumbo icon cacheMainWindowtitle bar logic resilient to a nullXamlRootThe bad
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed