-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[MouseUtils] Implement MouseScrollRemap for horizontal scrolling (Fixes #44137) #44150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
…ature Add Reset to Defaults button in Settings Backup and Restore
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
…nd implement ETW tracing Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
…hortcut [WIP] Add Shift + MouseWheel shortcut for horizontal scrolling
|
@navuxneeth please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
|
||
| STRINGTABLE | ||
| BEGIN | ||
| IDS_MOUSESCROLLREMAP_NAME "Horizontal Scroll with Shift" |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
|
|
||
| PowerToysSettings::Settings settings(hinstance, get_name()); | ||
|
|
||
| settings.set_description(IDS_MOUSESCROLLREMAP_NAME); |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
| // Microsoft Visual C++ generated include file. | ||
| // Used by MouseScrollRemap.rc | ||
| // | ||
| #define IDS_MOUSESCROLLREMAP_NAME 101 |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a new PowerToys module called MouseScrollRemap that provides consistent horizontal scrolling behavior across applications by remapping Shift + MouseWheel to Shift + Ctrl + MouseWheel. Additionally, it adds a "Reset to Defaults" feature to the PowerToys settings UI that allows users to restore all settings to their default values.
Key Changes
- New C++ module implementing a low-level mouse hook to intercept scroll events when Shift is pressed (without Ctrl) and inject the Ctrl key to ensure Office-style horizontal scrolling works system-wide
- Settings UI enhancements with a "Reset to Defaults" button that deletes all settings files and restarts PowerToys
- Integration of the new module into the PowerToys runner, solution file, and documentation
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/modules/MouseUtils/MouseScrollRemap/* |
New module implementation with mouse hook, telemetry, resources, and project configuration |
src/runner/main.cpp |
Added MouseScrollRemap DLL to the module loading list |
src/common/logger/logger_settings.h |
Added logger name for the new module |
src/settings-ui/Settings.UI/ViewModels/GeneralViewModel.cs |
Added Reset to Defaults button handler |
src/settings-ui/Settings.UI.Library/SettingsBackupAndRestoreUtils.cs |
Implemented reset functionality to delete settings files |
src/settings-ui/Settings.UI/Strings/en-us/Resources.resw |
Added localization strings for reset feature |
src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml |
Added Reset to Defaults button to UI |
doc/devdocs/modules/mouseutils/readme.md |
Updated documentation to include the new module |
PowerToys.slnx |
Added MouseScrollRemap project to solution |
IMPLEMENTATION_SUMMARY.md |
Comprehensive implementation documentation and testing guide |
Comments suppressed due to low confidence (1)
src/settings-ui/Settings.UI.Library/SettingsBackupAndRestoreUtils.cs:1
- The doc comment is incomplete and imprecise. It should fully describe what the method does (deletes settings files to restore defaults) rather than describing it as 'mostly a wrapper' which is confusing since it's calling an instance method of the same class.
// Copyright (c) Microsoft Corporation
| // Constructor | ||
| MouseScrollRemap() | ||
| { | ||
| LoggerHelpers::init_logger(MODULE_NAME, L"ModuleInterface", LogSettings::mouseScrollRemapLoggerName); |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger is initialized in the constructor which could be called multiple times if the module is created multiple times. Consider moving logger initialization to DLL_PROCESS_ATTACH in DllMain to ensure it's only initialized once per process.
| bool shiftPressed = (GetAsyncKeyState(VK_SHIFT) & 0x8000) != 0; | ||
| bool ctrlPressed = (GetAsyncKeyState(VK_CONTROL) & 0x8000) != 0; |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetAsyncKeyState can return stale state if called from a hook callback. Consider using GetKeyState instead, which returns the key state at the time the message was posted to the message queue, providing more accurate results for hook procedures.
| bool shiftPressed = (GetAsyncKeyState(VK_SHIFT) & 0x8000) != 0; | |
| bool ctrlPressed = (GetAsyncKeyState(VK_CONTROL) & 0x8000) != 0; | |
| bool shiftPressed = (GetKeyState(VK_SHIFT) & 0x8000) != 0; | |
| bool ctrlPressed = (GetKeyState(VK_CONTROL) & 0x8000) != 0; |
| inputs[1].mi.mouseData = mouseData; | ||
| inputs[1].mi.dwFlags = MOUSEEVENTF_WHEEL; | ||
| inputs[1].mi.time = 0; | ||
| inputs[1].mi.dwExtraInfo = 0; |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider setting dwExtraInfo to a unique marker value (e.g., using GetMessageExtraInfo() or a custom constant) to distinguish injected events from real user input. This allows the hook to ignore its own injected events and prevents potential infinite loops.
| cd src\modules\MouseUtils\MouseScrollRemap | ||
| .\tools\build\build.ps1 |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build command references .\tools\build\build.ps1 from within the MouseScrollRemap directory, but this script likely doesn't exist at that path. The build commands should be corrected to reflect the actual PowerToys build process.
| cd src\modules\MouseUtils\MouseScrollRemap | |
| .\tools\build\build.ps1 | |
| # Build just the MouseScrollRemap project: | |
| .\tools\build\build.ps1 -projects src\modules\MouseUtils\MouseScrollRemap\MouseScrollRemap.vcxproj |
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
Co-authored-by: navuxneeth <139112397+navuxneeth@users.noreply.github.com>
…rors Fix forbidden grammar pattern and critical hook bugs in MouseScrollRemap
| const static wchar_t* MODULE_DESC = L"Remap Shift+MouseWheel to horizontal scrolling"; | ||
|
|
||
| // Signature to identify our own injected mouse events and prevent infinite loops | ||
| // Using a unique signature: 0x4D535352 represents 'RSSM' in ASCII (reverse of MSSR for MouseScrollRemap) |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
| const static wchar_t* MODULE_DESC = L"Remap Shift+MouseWheel to horizontal scrolling"; | ||
|
|
||
| // Signature to identify our own injected mouse events and prevent infinite loops | ||
| // Using a unique signature: 0x4D535352 represents 'RSSM' in ASCII (reverse of MSSR for MouseScrollRemap) |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (3)MOUSESCROLLREMAP These words are not needed and should be removedCLITo CVS Notavailable toolgoodTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:navuxneeth/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/20017574962/attempts/1' &&
git commit -m 'Update check-spelling metadata'If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
| } | ||
|
|
||
| // The PowerToy name that will be shown in the settings. | ||
| const static wchar_t* MODULE_NAME = L"MouseScrollRemap"; |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MODULE_NAME should be declared before its first usage on line 21, or LoggerHelpers::init_logger should use a string literal instead.
| bool shiftPressed = (GetKeyState(VK_SHIFT) & 0x8000) != 0; | ||
| bool ctrlPressed = (GetKeyState(VK_CONTROL) & 0x8000) != 0; |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetKeyState checks the key state when the message was retrieved from the message queue, not the current state. Use GetAsyncKeyState for real-time key state checking in a hook procedure, as documented in the Windows API. The README mentions GetAsyncKeyState but the code uses GetKeyState.
| bool shiftPressed = (GetKeyState(VK_SHIFT) & 0x8000) != 0; | |
| bool ctrlPressed = (GetKeyState(VK_CONTROL) & 0x8000) != 0; | |
| bool shiftPressed = (GetAsyncKeyState(VK_SHIFT) & 0x8000) != 0; | |
| bool ctrlPressed = (GetAsyncKeyState(VK_CONTROL) & 0x8000) != 0; |
|
|
||
| - **Hook Type**: WH_MOUSE_LL (low-level mouse hook) | ||
| - **Event Intercepted**: WM_MOUSEWHEEL | ||
| - **Key Detection**: Uses GetAsyncKeyState to check for Shift and Ctrl keys |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation states GetAsyncKeyState is used for key detection, but the actual implementation in dllmain.cpp uses GetKeyState. Update documentation to match implementation or fix the implementation to use GetAsyncKeyState.
| - **Key Detection**: Uses GetAsyncKeyState to check for Shift and Ctrl keys | |
| - **Key Detection**: Uses GetKeyState to check for Shift and Ctrl keys |
|
|
||
| ### API Usage | ||
| ✅ **PASSED**: | ||
| - GetAsyncKeyState used appropriately for modifier key detection |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security review mentions GetAsyncKeyState but the implementation uses GetKeyState. This documentation should be updated to reflect the actual API being used.
| - GetAsyncKeyState used appropriately for modifier key detection | |
| - GetKeyState used appropriately for modifier key detection |
| #### How It Works | ||
| 1. **Hook Installation**: When enabled, the module installs a low-level mouse hook (WH_MOUSE_LL) using SetWindowsHookEx | ||
| 2. **Event Detection**: The hook monitors WM_MOUSEWHEEL events | ||
| 3. **Modifier Key Check**: Uses GetAsyncKeyState to detect if Shift is pressed but Ctrl is not |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation incorrectly states GetAsyncKeyState is used for modifier key detection. The implementation uses GetKeyState. Update documentation to match the actual implementation.
| 3. **Modifier Key Check**: Uses GetAsyncKeyState to detect if Shift is pressed but Ctrl is not | |
| 3. **Modifier Key Check**: Uses GetKeyState to detect if Shift is pressed but Ctrl is not |
|
@navuxneeth Have you compiled and tested this? |
Hey @zadjii-msft, I am currently testing and reworking on the files. I will post another PR for review once I'm done. |
You can update this pull request without making another one :) |
Summary of the Pull Request
This PR implements a new PowerToys module, MouseScrollRemap, which addresses the inconsistency in horizontal scrolling behavior between different applications.
Many applications (Chrome, JetBrains, GIMP) use
Shift + MouseWheelfor horizontal scrolling, while Microsoft Office applications (Word, Excel) requireShift + Ctrl + MouseWheel. This module introduces a global utility that interceptsShift + MouseWheeland injects the necessaryCtrlkey event to ensure consistent horizontal scrolling across the OS, specifically targeting the Office suite behavior.PR Checklist
Detailed Description of the Pull Request / Additional comments
Implementation Details:
src/modules/MouseUtils/MouseScrollRemap.Shiftis pressed (andCtrlis not), the hook intercepts the scroll event and injects aCtrlkey press + Mouse Wheel +Ctrlkey release sequence.Security:
SECURITY_REVIEW.mdhas been included in the module folder.Validation Steps Performed
Due to current environment limitations, I was unable to compile and run the full PowerToys solution locally to verify the runtime behavior.
However, the code has been implemented following PowerToys coding standards and C++ best practices. I have provided a detailed
IMPLEMENTATION_SUMMARY.mdin the codebase with a proposed test plan for the maintainer who picks this up.Proposed Verification Steps:
Shiftand scroll the mouse wheel (ensure the sheet scrolls horizontally).Shift + Scrollbehavior in Chrome is not negatively impacted.