MLE-26427 Namespace support for exclusions #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR adds namespace support for XML exclusions in the incremental write filtering functionality. The change allows XPath expressions in XML exclusions to reference namespaced elements by providing a prefix-to-URI mapping.
Changes:
- Added
xmlNamespacesparameter to support namespace prefixes in XPath exclusion expressions - Created
SimpleNamespaceContextclass to implementjavax.xml.namespace.NamespaceContext - Updated signature of
ContentExclusionUtil.applyXmlExclusionsto accept namespace mappings
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ApplyExclusionsToIncrementalWriteTest.java | Added test case verifying XML exclusions work correctly with namespaced elements |
| SimpleNamespaceContext.java | New class implementing NamespaceContext for namespace-aware XPath evaluation |
| IncrementalWriteFilter.java | Added xmlNamespaces builder method and validation; updated constructor signatures |
| IncrementalWriteOpticFilter.java | Updated constructor to pass xmlNamespaces parameter through inheritance chain |
| IncrementalWriteEvalFilter.java | Updated constructor to pass xmlNamespaces parameter through inheritance chain |
| ContentExclusionUtil.java | Modified applyXmlExclusions methods to accept and use namespace mappings |
Comments suppressed due to low confidence (2)
marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/ApplyExclusionsToIncrementalWriteTest.java:1
- Test data uses dates in 2026, which is in the future. Consider using dates relative to the current date or fixed past dates to avoid confusion.
/*
marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/ApplyExclusionsToIncrementalWriteTest.java:1
- Test data uses dates in 2026, which is in the future. Consider using dates relative to the current date or fixed past dates to avoid confusion.
/*
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (namespaces != null && !namespaces.isEmpty()) { | ||
| xpath.setNamespaceContext(new SimpleNamespaceContext(namespaces)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove the trailing whitespace on this blank line to maintain consistent code formatting.
Suggested change
Comment on lines
+123
to
+124
| * @param namespaces a map of namespace prefixes to URIs for use in XPath exclusion expressions. | ||
| * For example, Map.of("ns", "http://example.com/ns") allows XPath like "//ns:timestamp". |
BillFarber
reviewed
Jan 16, 2026
...est/java/com/marklogic/client/datamovement/filter/ApplyExclusionsToIncrementalWriteTest.java
Show resolved
Hide resolved
BillFarber
previously approved these changes
Jan 16, 2026
gitflow-feature-stash: namespacaes
rjrudin
force-pushed
the
feature/namespacaes
branch
from
4163c2f to
0ab46c8
Compare
BillFarber
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitflow-feature-stash: namespacaes