-
Notifications
You must be signed in to change notification settings - Fork 860
style: shadow adjustments #7700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@m-rgba 1px to 2px border swapping is going to cause a layout shift, which we would like to avoid |
@mscolnick gotcha, that's fair - we could look at something like an outline pattern to have a similar effect without the shift on focus. Updated with an example of that. outline-pattern.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this! The outline approach looks good and addresses the layout shift concern.
We're aligned with the direction here. The hover state improvement and cleaner shadow treatment are nice additions. We had some parallel work happening on our side (#7692) which unfortunately led to some wasted effort. These changes are definitely in the direction we want, but in the future it would be great to align on goals before diving into implementation so we can avoid stepping on each other's toes. Thanks again for the great contribution!
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev157 |
📝 Summary
cell-styling.mov
tabIndexto error output (so that clicking outputs triggers focus-within vs our outline).