Skip to content

Conversation

@m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Jan 6, 2026

📝 Summary

Before After
image image
cell-styling.mov
  • Adds hover state (darker border) to default / has-error / needs-run cells.
  • Uses 2px border for inactive state for emphasized cells (has-error / needs-run) - instead of 1px / solid shadow.
    • Reverts to 1px when focused.
  • Adds tabIndex to error output (so that clicking outputs triggers focus-within vs our outline).

@vercel
Copy link

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jan 7, 2026 1:29am

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@m-rgba
Copy link
Contributor Author

m-rgba commented Jan 6, 2026

I have read the CLA Document and I hereby sign the CLA

@m-rgba m-rgba marked this pull request as ready for review January 6, 2026 21:43
@mscolnick
Copy link
Contributor

mscolnick commented Jan 6, 2026

@m-rgba 1px to 2px border swapping is going to cause a layout shift, which we would like to avoid

@m-rgba
Copy link
Contributor Author

m-rgba commented Jan 6, 2026

@m-rgba 1px to 2px border swapping is going to cause a layout shift, which we would like to avoid

@mscolnick gotcha, that's fair - we could look at something like an outline pattern to have a similar effect without the shift on focus. Updated with an example of that.

outline-pattern.mov

Copy link
Contributor

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this! The outline approach looks good and addresses the layout shift concern.

We're aligned with the direction here. The hover state improvement and cleaner shadow treatment are nice additions. We had some parallel work happening on our side (#7692) which unfortunately led to some wasted effort. These changes are definitely in the direction we want, but in the future it would be great to align on goals before diving into implementation so we can avoid stepping on each other's toes. Thanks again for the great contribution!

@akshayka akshayka merged commit e4ddc4f into marimo-team:main Jan 7, 2026
28 of 29 checks passed
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants