Skip to content

Conversation

@Light2Dark
Copy link
Contributor

📝 Summary

Fixes https://discord.com/channels/1059888774789730424/1354822538055647262/1450792692991656120

We should get the relative URL instead of the absolute path. This was regressed (tested an older version and it returned relative url). Also adds a warning + return if decline to save the file.

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@Light2Dark Light2Dark requested a review from manzt as a code owner December 17, 2025 20:48
@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Dec 17, 2025 8:48pm

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mscolnick mscolnick merged commit a0e8170 into main Dec 17, 2025
26 checks passed
@mscolnick mscolnick deleted the sham/fix-relative-url-image-inserts branch December 17, 2025 22:33
@Light2Dark Light2Dark mentioned this pull request Dec 22, 2025
1 task
@dmadisetti dmadisetti added the bug Something isn't working label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants