Skip to content

Conversation

@koaning
Copy link
Contributor

@koaning koaning commented Nov 4, 2025

We have an unstyled bit of form text when you start marimo in headless mode without a token in the url. This PR tries to fix that.

Before:

CleanShot 2025-11-04 at 17 08 34

After:

CleanShot 2025-11-04 at 17 12 24

@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 4, 2025 7:13pm

@koaning koaning added the enhancement New feature or request label Nov 4, 2025
Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-family should have some fallbacks

@koaning
Copy link
Contributor Author

koaning commented Nov 4, 2025

Ah, right. fallback for browser, will check if Arial is a default.

@koaning
Copy link
Contributor Author

koaning commented Nov 4, 2025

@mscolnick I don't know if this makes it "available everywhere" but it does seem like Arial is a web safe font, does that suffice?

@mscolnick mscolnick requested a review from Copilot November 4, 2025 18:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a font-family specification to the login form's label styling to improve visual consistency.

Key Changes:

  • Added font-family: Arial; to the password label styling in the login endpoint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mscolnick
mscolnick approved these changes Nov 4, 2025
@mscolnick mscolnick merged commit 899ae25 into main Nov 4, 2025
39 of 41 checks passed
@mscolnick mscolnick deleted the better-token-font branch November 4, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants