Skip to content

Conversation

@lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Nov 13, 2025

GeoJSONSource#updateData did not work with the promoteId or cluster options.

Inspired by #6690 (comment)
Ref #4364
Ref #6562

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@lucaswoj lucaswoj marked this pull request as ready for review November 13, 2025 21:42
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.21%. Comparing base (ad813fa) to head (074787d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6704   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         285      285           
  Lines       23732    23733    +1     
  Branches     5053     5053           
=======================================
+ Hits        21884    21885    +1     
  Misses       1848     1848           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM
Copy link
Collaborator

HarelM commented Nov 14, 2025

@lucaswoj are you planning more changes as part of this PR or can this be merged?
At its current state, this PR can be merged, I don't have any code review comments.

@lucaswoj
Copy link
Contributor Author

This is ready to merge

@HarelM HarelM merged commit 767a245 into maplibre:main Nov 14, 2025
26 checks passed
mmc1718 pushed a commit to mmc1718/maplibre-gl-js that referenced this pull request Nov 20, 2025
melitele pushed a commit to melitele/maplibre-gl-js that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants