-
-
Notifications
You must be signed in to change notification settings - Fork 976
Fix promoteId support for GeoJSONSource#updateData #6703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86243bb to
8c0eb4c
Compare
lucaswoj
commented
Nov 13, 2025
lucaswoj
commented
Nov 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6703 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 285 286 +1
Lines 23732 23731 -1
Branches 5053 5052 -1
==========================================
- Hits 21884 21883 -1
Misses 1848 1848 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Interaction with clustering needs more thought |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoJSONSource#updateDatadid not work withpromoteId. This PR fixes support and establishes a single point of truth for thegetFeatureIdoperation.Inspired by #6690 (comment)
Ref #4364
Ref #6562
Launch Checklist
Include before/after visuals or gifs if this PR includes visual changes.Document any changes to public APIs.Post benchmark scores.CHANGELOG.mdunder the## mainsection.