Fix issue where parent tiles are retained when deeper descendant tiles already cover the missing ideal tile. #6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r an ideal tile covered by 2nd generation children
wayofthefuture
changed the title
HarelM
reviewed
Sep 20, 2025
HarelM
reviewed
Sep 20, 2025
Collaborator
|
Looks good otherwise, thanks again for digging into this! |
wayofthefuture
force-pushed
the
fix-double-retain
branch
from
dbf6a69 to
a91eed7
Compare
wayofthefuture
force-pushed
the
fix-double-retain
branch
from
a91eed7 to
7133f51
Compare
Collaborator
Author
|
I forgot to remove the throw test then mispelled the commit! Sorry for the force pushes. Otherwise, all done! |
HarelM
approved these changes
Sep 21, 2025
melitele
pushed a commit
to melitele/maplibre-gl-js
that referenced
this pull request
Jan 8, 2026
…s already cover the missing ideal tile. (maplibre#6442) * Add failing test to show where parent tiles are retained/requested for an ideal tile covered by 2nd generation children * add appropriate tests and modify nth generational retainment logic * change log, build size * rename test, remove throw --------- Co-authored-by: wayofthefuture <wayofthefuture@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where parent tiles were being retained/requested even when deeper descendant tiles already covered the missing ideal tile.
Background
Previously, _updateRetainedTiles only checked one level of children before falling back to parent tiles. Meanwhile, _retainLoadedChildren correctly seeks descendants up to maxCoveringZoom (e.g. 4, 16, 64 tiles for successive generations). This mismatch causes unnecessary parent retainment.
Change
Instead of duplicating multi-generation logic in _updateRetainedTiles, the function now relies on _retainLoadedChildren to report ideal tiles with incomplete descendants. This keeps the logic consistent and prevents redundant parent retainment/requests.
CHANGELOG.mdunder the## mainsection.