-
Notifications
You must be signed in to change notification settings - Fork 19.5k
feat: enhance start node object value check #30732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the validation process for JSON object inputs within start nodes. It adds a crucial type check to ensure that after a value is parsed as JSON, it strictly conforms to the expected dictionary type. This enhancement improves data integrity by preventing malformed or incorrectly typed JSON values from proceeding through the workflow, addressing a potential edge case where non-object JSON could bypass initial parsing but cause issues later. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly enhances validation for JSON_OBJECT variables by ensuring the provided value is a dictionary. The change is a good improvement. However, this validation is only applied when a json_schema is present. It would be more robust to apply this check for all JSON_OBJECT variables, regardless of schema presence. Also, please ensure tests for this new logic are included, as they appear to be missing from the pull request despite being checked in the description.
QuantumGhost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Important
Fixes #<issue number>.Summary
fix #30731
enhance start node object value check
Screenshots
after
Screen.Recording.2026-01-08.at.16.41.06.mov
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods