Skip to content

Conversation

@hieheihei
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Set root span kind to SERVER for AliyunTrace to enable service-level metrics aggregation in Aliyun observability backend.

The Aliyun observability backend calculates service metrics based on span kind. Setting root spans to SERVER enables proper service metrics tracking (request rate, latency, error rate).

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hieheihei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the accuracy of service-level metrics aggregation within the Aliyun observability backend by correctly classifying root spans. By explicitly setting the "SpanKind" of initial traces to "SERVER", the Aliyun system can now properly track and report key performance indicators such as request rate, latency, and error rates, providing better insights into application performance.

Highlights

  • Enhanced Aliyun Trace Span Kind Configuration: Introduced the "SpanKind" enum into the "SpanData" entity and updated the "traceclient" to dynamically use this "span_kind" when building spans, allowing for more granular control over span classification.
  • Correct Root Span Classification for AliyunTrace: Configured root spans generated by "message_trace" and "add_workflow_span" to be explicitly set as "SpanKind.SERVER". This ensures that service-level metrics are correctly aggregated by the Aliyun observability backend.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the setting of SpanKind for root spans in AliyunTrace to SERVER, which will enable proper service-level metrics aggregation in the Aliyun observability backend. The changes are well-structured: the SpanData entity is extended to carry the span_kind, the trace creation logic in aliyun_trace.py correctly identifies and sets the kind for root spans, and the traceclient is updated to use this new information. The use of a default SpanKind.INTERNAL ensures that existing code continues to function as before. The implementation is clean and effectively addresses the stated goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant