Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 8, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30712

fix copy node z-index is not right

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@fatelei fatelei requested review from iamjoel and zxhlyh as code owners January 8, 2026 02:21
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where copied nodes, particularly those pasted into Loop blocks, exhibited incorrect z-index stacking, leading to display problems. The changes ensure that pasted nodes maintain their proper visual layering and that their parent-child relationships are accurately established within the workflow editor, improving the consistency and reliability of node interactions.

Highlights

  • Corrected Z-Index for Copied Loop Children: When nodes are copied and pasted into a Loop block, their zIndex is now correctly set to LOOP_CHILDREN_Z_INDEX, resolving display order issues where nodes might appear incorrectly layered.
  • Improved Parent-Child Relationship Handling on Paste: The logic for pasting nodes into Iteration and Loop blocks has been enhanced to correctly update the parent node's _children array, ensuring that the parent node properly recognizes its newly pasted children.
  • Accurate Parent ID Assignment: The iteration_id and loop_id for pasted child nodes are now correctly assigned using the id of the parent selectedNode, rather than potentially incorrect data properties, ensuring proper nesting.
  • Consistent Node Properties for New Loop Children: New nodes generated within a loop now consistently receive _dimmed: false, isInLoop: true, loop_id, and type properties, ensuring their correct behavior and appearance within the loop context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where the z-index of a copied node was not being set correctly when pasted into a Loop block. The changes look good overall. I've added one comment with a suggestion to refactor a section of the code. This refactoring would not only reduce duplication but also fix a related bug where the z-index was missed for nodes pasted into Iteration blocks, and another potential bug related to inconsistent node state when pasting between different container types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nodes pasted inside loop have invalid opacity / z-index

1 participant