-
Notifications
You must be signed in to change notification settings - Fork 19.5k
revert: "fix: fix assign value stand as default (#30651)" #30717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 187bfaf.
Summary of ChangesHello @QuantumGhost, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a full revert of a prior fix, specifically removing functionality in the advanced chat pipeline that handled dynamic updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change that added logic to update the final answer in advanced chat applications after streaming. The changes consist of removing the specific logic for ANSWER nodes from _handle_node_succeeded_event in generate_task_pipeline.py and deleting the corresponding test file. The revert is implemented cleanly, with both the feature code and its dedicated tests being removed. I find no issues with the implementation of this revert.
Reverts #30651
The original fix seems correct on its own. However, for chatflows with multiple answer nodes, the
message_replacecommand only preserves the output of the last executed answer node.The follow DSL is an example:
DSL