-
Notifications
You must be signed in to change notification settings - Fork 19.5k
refactor(variables): clarify base vs union type naming #30634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…n to Variable Updated core variable definitions and propagated the base/union naming change through workflow runtime, services, and tests. Tests not run (not requested). Next steps: 1. `uv run --project api --dev dev/pytest/pytest_unit_tests.sh` 2. `make lint` 3. `make type-check`
Summary of ChangesHello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the core variable type definitions to improve clarity and maintainability. By renaming the base class to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a large-scale refactoring that renames Variable to VariableBase and VariableUnion to Variable to improve type name clarity. The changes are applied consistently across the entire codebase, including application logic, workflow components, models, and tests. My review confirms that the renaming has been executed thoroughly. I've identified one minor opportunity to improve a comment for better code clarity and maintainability. Overall, this is a solid refactoring that enhances the readability of the code.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Important
Fixes #<issue number>.Summary
Refactors variable type naming so the abstract base class is
VariableBaseand the Pydantic union isVariable, updating imports and type hints across workflow/runtime/services/tests for clarity.Fixes #30632
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods