Skip to content

Conversation

@laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Refactors variable type naming so the abstract base class is VariableBase and the Pydantic union is Variable, updating imports and type hints across workflow/runtime/services/tests for clarity.
Fixes #30632

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

…n to Variable

Updated core variable definitions and propagated the base/union naming change through workflow runtime, services, and tests.
Tests not run (not requested).

Next steps:
1. `uv run --project api --dev dev/pytest/pytest_unit_tests.sh`
2. `make lint`
3. `make type-check`
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the core variable type definitions to improve clarity and maintainability. By renaming the base class to VariableBase and the Pydantic union type to Variable, the distinction between the abstract definition and the concrete, serializable representation of variables is made explicit. This change propagates throughout the application, updating all references to these types for consistency.

Highlights

  • Type Renaming: The base class for variables, previously named Variable, has been renamed to VariableBase. This change clarifies its role as an abstract base class for all specific variable types.
  • Union Type Simplification: The VariableUnion type alias, which represents a union of all concrete variable types and is primarily used for Pydantic serialization and deserialization, has been renamed to Variable. This makes the type name more intuitive and aligns with common usage patterns.
  • Codebase-wide Consistency: All relevant files across the codebase have been updated to reflect these new naming conventions. This includes changes to imports, type hints, isinstance checks, and comments, ensuring a consistent and clear variable type system throughout the project.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@laipz8200 laipz8200 changed the title Rename Variable to VariableBase, then rename VariableUnion to Variable to make the type name clear (vibe-kanban) refactor(variables): clarify base vs union type naming Jan 6, 2026
@laipz8200 laipz8200 marked this pull request as ready for review January 6, 2026 10:00
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a large-scale refactoring that renames Variable to VariableBase and VariableUnion to Variable to improve type name clarity. The changes are applied consistently across the entire codebase, including application logic, workflow components, models, and tests. My review confirms that the renaming has been executed thoroughly. I've identified one minor opportunity to improve a comment for better code clarity and maintainability. Overall, this is a solid refactoring that enhances the readability of the code.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
QuantumGhost
QuantumGhost previously approved these changes Jan 7, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor/Chore] Clarify variable type naming

4 participants