Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 6, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

resolve #30595

  • not use flask context directly in workflow
  • use di to pass the flask context
  • use register model

add method register_context_capturer to register context, later call capture_current_context to fetch the context, register_context_capturer can register many context, so workflow can use different context, to decouple the flask context, the workflow can not see the flask context.

# Usage Flow

# 1. Flask app initialization (app_factory.py)
init_flask_context()  # Registers Flask capturer

# 2. Workflow execution (framework-agnostic)
from core.context import capture_current_context
ctx = capture_current_context()  # Uses registered capturer

# This achieves true architectural decoupling - the workflow layer is completely unaware of Flask's existence.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Jan 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the workflow context management by introducing an abstraction layer to decouple workflow execution from direct Flask context dependencies. This change aims to enhance the system's robustness, particularly in multi-threaded environments, and improve testability by allowing contexts to be explicitly managed and passed through dependency injection. The core idea is to move away from implicit global state to explicit context objects, making the codebase more maintainable and scalable.

Highlights

  • Decoupling Flask Context: The workflow execution logic has been refactored to no longer directly depend on Flask's application context. This improves modularity and testability.
  • Introduction of Execution Context Abstraction: A new core.workflow.context package has been introduced, providing an abstract AppContext and a concrete ExecutionContext to manage application context, Python contextvars, and user information in a Flask-independent manner.
  • Dependency Injection for Context: Instead of implicitly relying on Flask's global context, the new IExecutionContext interface is now explicitly passed to worker threads and iteration nodes, enabling clearer dependency management.
  • Database Session Management: The app_generator.py now utilizes session_factory.create_session() for database sessions, further centralizing and abstracting database access.
  • Improved User Resolution: The workflow_as_tool module now uses a new helper function _try_resolve_user_from_request to abstract the process of resolving user information from the Flask request context.
  • Enhanced Testability: New unit tests have been added for the execution_context and flask_app_context modules, ensuring the robustness and correctness of the new context management system.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and valuable refactoring by abstracting the Flask context dependency within the workflow engine. The new ExecutionContext abstraction, along with its Flask-specific and null implementations, greatly improves the modularity, testability, and portability of the code. The changes are well-structured and the addition of unit tests for the new context management system is commendable.

I've identified a critical issue in _try_resolve_user_from_request that could lead to a RuntimeError, and a medium-severity issue regarding code duplication in FlaskExecutionContext. Addressing these will make the implementation more robust and maintainable.

Additionally, I noticed that app_generator.py still uses the old preserve_flask_contexts for its worker thread. While this is outside the scope of the changed lines in this PR, I recommend creating a follow-up task to refactor it to use the new ExecutionContext for consistency across the codebase.

@fatelei fatelei force-pushed the refactor_workflow_context branch 2 times, most recently from fd111d3 to e4ba676 Compare January 6, 2026 06:50
@fatelei fatelei force-pushed the refactor_workflow_context branch from e4ba676 to c4227a2 Compare January 6, 2026 09:38
@fatelei fatelei force-pushed the refactor_workflow_context branch from c4227a2 to db6a7cd Compare January 9, 2026 06:30
@fatelei fatelei force-pushed the refactor_workflow_context branch from 6d9264a to 1924fb3 Compare January 9, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌊 feat:workflow Workflow related stuff. size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DI flask context in workflow

2 participants