-
Notifications
You must be signed in to change notification settings - Fork 19.5k
fix: enhance agent node convert_template by recursive render all str fields #30528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hoffermei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the template rendering capabilities within the workflow's variable pool. By introducing a recursive rendering mechanism, it allows for seamless variable substitution across complex and nested data structures, including Pydantic models. This change streamlines how agent nodes process their inputs, making the system more flexible and robust in handling diverse data types that contain template strings. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant enhancement to template rendering by adding a render_template method to the VariablePool. This new method recursively processes nested data structures like lists, dictionaries, and Pydantic models, rendering any string template variables it finds. This is a much cleaner approach than the previous method of JSON-stringifying objects before rendering.
The changes in agent_node.py correctly adopt this new method within a try...except block, ensuring a safe fallback to the old logic, which is a good practice for this kind of refactoring. The accompanying unit tests for render_template are comprehensive and cover a wide range of scenarios, which is excellent.
My review includes a couple of suggestions for improvement: one regarding adding type hints for better code clarity and another to strengthen a test assertion to make the behavior of a related function more explicit.
f029ec6 to
e43ccbe
Compare
fixes #30527
Important
Fixes #<issue number>.Summary
When agent node tool reference a variable which is a multiple line string, run agent node with
'str' object has no attribute 'get', this pr fix the variable render problem by scan and render str value onlyScreenshots
|


|
|
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods